Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experimental grpc module #1223

Merged
merged 5 commits into from
Jun 19, 2023
Merged

Experimental grpc module #1223

merged 5 commits into from
Jun 19, 2023

Conversation

olegbespalov
Copy link
Contributor

@olegbespalov olegbespalov commented Jun 14, 2023 •
edited
Loading

What?

Adding the documentation about the experimental GRPC module.

There are two commits; the first is just a copy of the original documentation from the k6/net/grpc. So the most notable changes could be found in 7a845d7

Why?

We are going to release such functionality.

grafana/k6#2020

@github-actions
Copy link
Contributor

There's a version of the docs published here:

https://mdr-ci.staging.k6.io/docs/refs/pull/1223/merge

It will be deleted automatically in 30 days.

@olegbespalov olegbespalov force-pushed the feat/grpc-experimental branch from 942cc51 to 2d2247e Compare June 14, 2023 08:21
@olegbespalov olegbespalov changed the title Feat/grpc experimental Experimental grpc module Jun 14, 2023
@olegbespalov olegbespalov force-pushed the feat/grpc-experimental branch from 2d2247e to 7a845d7 Compare June 14, 2023 09:42
@olegbespalov olegbespalov marked this pull request as ready for review June 14, 2023 09:51
@olegbespalov olegbespalov force-pushed the feat/grpc-experimental branch from 1ba1a78 to 2bfc0f4 Compare June 14, 2023 13:01
@olegbespalov olegbespalov requested a review from codebien June 14, 2023 13:10
codebien
codebien approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@codebien codebien left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I've just spot a minor thing

@olegbespalov olegbespalov force-pushed the feat/grpc-experimental branch from 4776c93 to 9974f12 Compare June 16, 2023 07:05
@olegbespalov @codebien
GRPC streaming
903534a 
Co-authored-by: Ivan <2103732+codebien@users.noreply.github.com>
@olegbespalov olegbespalov force-pushed the feat/grpc-experimental branch from 9974f12 to 903534a Compare June 16, 2023 07:08
ppcano
ppcano requested changes Jun 19, 2023
View reviewed changes
Copy link
Collaborator

@ppcano ppcano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add blockquotes such in:

@olegbespalov olegbespalov requested a review from ppcano June 19, 2023 07:17
ppcano added 2 commits June 19, 2023 09:24
@ppcano
Merge branch 'main' into feat/grpc-experimental
7c0fef1 
* main:
  Update 05 resources.md
  Update k6/crypto to recommend the webcrypto API (#1224)
  Update `Experimental module` admonition (#1225)
  Update `k6/ws` blockquote to refer the experimental module (#1226)
  Tutorial: Get started with k6 (#1192)
@ppcano
Sort experimental grpc module
bc42502
@mstoykov mstoykov merged commit 15eba58 into main Jun 19, 2023
@mstoykov mstoykov deleted the feat/grpc-experimental branch June 19, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebien codebien codebien approved these changes

@mstoykov mstoykov mstoykov approved these changes

@ppcano ppcano Awaiting requested review from ppcano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@olegbespalov @mstoykov @ppcano @codebien