Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xk6-sse extension #1541

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Add xk6-sse extension #1541

merged 3 commits into from
Apr 16, 2024

Conversation

phymbert
Copy link
Contributor

@phymbert phymbert commented Apr 4, 2024

@phymbert phymbert requested a review from heitortsergent as a code owner April 4, 2024 23:04
@CLAassistant
Copy link

CLAassistant commented Apr 4, 2024

CLA assistant check
All committers have signed the CLA.

@pablochacin pablochacin self-assigned this Apr 12, 2024
@pablochacin
Copy link
Contributor

Hi @phymbert Thanks for your contribution. The documentation folks (thanks @heitortsergent!) pointed out that in order to this change to appear in the documentation you have to update https://github.com/grafana/k6-docs/blob/main/docs/sources/v0.50.x/extensions/explore.md

You can take this PR as a model https://github.com/grafana/k6-docs/pull/1538/files

@phymbert
Copy link
Contributor Author

@pablochacin Thanks done

Copy link
Collaborator

@heitortsergent heitortsergent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating an extension and adding it to our docs! 🙇

@heitortsergent heitortsergent merged commit d07abde into grafana:main Apr 16, 2024
5 checks passed
@phymbert phymbert deleted the hp/xk6-sse branch April 16, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants