Fix an error in the http.Params.timeout description #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstoykov
approved these changes
Nov 17, 2020
|
There's a version of the docs published here: https://mdr-ci.staging.k6.io/docs/refs/pull/155/merge It will be deleted automatically in 30 days. |
imiric
approved these changes
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was a bit overzealous in #144 and didn't notice that my
timeoutsearch-and-replace also affected the HTTP docs, not only the gRPC ones. Unfortunately,http.Params.timeoutstill doesn't accept string-y values, we haven't implemented grafana/k6#1305 yet 😞 Hopefully soon...