Update to Async BrowserContext
#1590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inancgumus
requested review from
ankur22
and removed request for
heitortsergent and
ankur22
inancgumus
force-pushed
the
async/browsercontext
branch
from
1401f15
to
55f97f1
Compare
allansson
approved these changes
May 20, 2024
docs/sources/next/javascript-api/k6-experimental/browser/browsercontext/grantpermissions.md
Show resolved
Hide resolved
docs/sources/next/javascript-api/k6-experimental/browser/browsercontext/cookies.md
Show resolved
Hide resolved
ankur22
approved these changes
May 20, 2024
docs/sources/next/javascript-api/k6-experimental/browser/browsercontext/close.md
Outdated
Show resolved
Hide resolved
docs/sources/next/javascript-api/k6-experimental/browser/browsercontext/pages.md
Outdated
Show resolved
Hide resolved
| @@ -5,14 +5,20 @@ description: 'Clears context cookies.' | |||
|
|
|||
| # addCookies() | |||
|
|
|||
| Adds a list of [cookies](https://grafana.com/docs/k6/<K6_VERSION>/javascript-api/k6-experimental/browser/browsercontext/cookie) into the [BrowserContext](https://grafana.com/docs/k6/<K6_VERSION>/javascript-api/k6-experimental/browser/browsercontext/cookie). All pages within this [BrowserContext](https://grafana.com/docs/k6/<K6_VERSION>/javascript-api/k6-experimental/browser/browsercontext/cookie) will have these [cookies](https://grafana.com/docs/k6/<K6_VERSION>/javascript-api/k6-experimental/browser/browsercontext/cookie) set. | |||
| Adds a list of [cookies](https://grafana.com/docs/k6/<K6_VERSION>/javascript-api/k6-experimental/browser/browsercontext/cookie) into the [browser context](https://grafana.com/docs/k6/<K6_VERSION>/javascript-api/k6-experimental/browser/browsercontext/). All pages within this [browser context](https://grafana.com/docs/k6/<K6_VERSION>/javascript-api/k6-experimental/browser/browsercontext/) will have these [cookies](https://grafana.com/docs/k6/<K6_VERSION>/javascript-api/k6-experimental/browser/browsercontext/cookie) set. | |||
There was a problem hiding this comment.
I'm not sure about the BrowserContext to browser context change. I think it makes it easier for the user to see it used in one way, so that they can easily understand the relationship between all the components.
Why did you make the change?
There was a problem hiding this comment.
It was easier to read in a sentence. We've been using this pattern in other places (before this PR), too. I've created an issue to keep everything consistent: #1596.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update relevant
BrowserContextmethods from sync to async.Checklist
npm startcommand locally and verified that the changes look good.docs/sources/nextfolder of the documentation.docs/sources/v{most_recent_release}folder of the documentation.Related PR(s)/Issue(s)
grafana/xk6-browser#1295