Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sleep and page.waitForTimeout doc to v0.52 & v0.53 #1743

Merged
merged 6 commits into from
Sep 27, 2024

Conversation

ankur22
Copy link
Contributor

@ankur22 ankur22 commented Sep 25, 2024

What?

Add sleep and page.waitForTimeout doc to v0.52 & v0.53. It's a new recommended best practice doc for the browser module.

Checklist

  • I have used a meaningful title for the PR.
  • I have described the changes I've made in the "What?" section above.
  • I have performed a self-review of my changes.
  • I have run the npm start command locally and verified that the changes look good.
  • I have made my changes in the docs/sources/next folder of the documentation.
  • I have reflected my changes in the docs/sources/v{most_recent_release} folder of the documentation.
  • I have reflected my changes in the relevant folders of the two previous k6 versions of the documentation (if still applicable to previous versions).

Related PR(s)/Issue(s)

Updates: #1719

Copy link
Collaborator

@heitortsergent heitortsergent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really awesome @ankur22, thanks for creating this! I made some small suggestions, mostly style related.

Another thing I wanted to point out, once this is ready to merge, we should apply the changes to the next folder as well so the docs stay in sync in future releases.

@ankur22 ankur22 force-pushed the add/sleep-wait-browser-v0.52-v0.53 branch from 8a34ef9 to 8ecb7fb Compare September 27, 2024 10:32
@ankur22
Copy link
Contributor Author

ankur22 commented Sep 27, 2024

Thanks for the review @heitortsergent! I've used all your suggestions in all versions of the doc, including in the next section.

Copy link
Collaborator

@heitortsergent heitortsergent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Member

@inancgumus inancgumus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ankur22 ankur22 force-pushed the add/sleep-wait-browser-v0.52-v0.53 branch from 989d651 to 5a15396 Compare September 27, 2024 16:21
@ankur22 ankur22 merged commit d219af5 into main Sep 27, 2024
5 checks passed
@ankur22 ankur22 deleted the add/sleep-wait-browser-v0.52-v0.53 branch September 27, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants