-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sleep and page.waitForTimeout doc to v0.52 & v0.53 #1743
Conversation
2510587
to
55bb905
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really awesome @ankur22, thanks for creating this! I made some small suggestions, mostly style related.
Another thing I wanted to point out, once this is ready to merge, we should apply the changes to the next
folder as well so the docs stay in sync in future releases.
docs/sources/v0.52.x/using-k6-browser/recommended-practices/simulate-user-input-delay.md
Outdated
Show resolved
Hide resolved
docs/sources/v0.52.x/using-k6-browser/recommended-practices/simulate-user-input-delay.md
Outdated
Show resolved
Hide resolved
docs/sources/v0.52.x/using-k6-browser/recommended-practices/simulate-user-input-delay.md
Outdated
Show resolved
Hide resolved
docs/sources/v0.52.x/using-k6-browser/recommended-practices/simulate-user-input-delay.md
Outdated
Show resolved
Hide resolved
docs/sources/v0.52.x/using-k6-browser/recommended-practices/simulate-user-input-delay.md
Outdated
Show resolved
Hide resolved
docs/sources/v0.52.x/using-k6-browser/recommended-practices/simulate-user-input-delay.md
Outdated
Show resolved
Hide resolved
docs/sources/v0.52.x/using-k6-browser/recommended-practices/simulate-user-input-delay.md
Outdated
Show resolved
Hide resolved
docs/sources/v0.52.x/using-k6-browser/recommended-practices/simulate-user-input-delay.md
Outdated
Show resolved
Hide resolved
docs/sources/v0.52.x/using-k6-browser/recommended-practices/simulate-user-input-delay.md
Outdated
Show resolved
Hide resolved
docs/sources/v0.52.x/using-k6-browser/recommended-practices/simulate-user-input-delay.md
Outdated
Show resolved
Hide resolved
8a34ef9
to
8ecb7fb
Compare
Thanks for the review @heitortsergent! I've used all your suggestions in all versions of the doc, including in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
docs/sources/v0.52.x/using-k6-browser/recommended-practices/simulate-user-input-delay.md
Outdated
Show resolved
Hide resolved
docs/sources/v0.52.x/using-k6-browser/recommended-practices/simulate-user-input-delay.md
Outdated
Show resolved
Hide resolved
docs/sources/v0.52.x/using-k6-browser/recommended-practices/simulate-user-input-delay.md
Outdated
Show resolved
Hide resolved
docs/sources/v0.53.x/using-k6-browser/recommended-practices/simulate-user-input-delay.md
Outdated
Show resolved
Hide resolved
docs/sources/v0.53.x/using-k6-browser/recommended-practices/simulate-user-input-delay.md
Outdated
Show resolved
Hide resolved
docs/sources/v0.53.x/using-k6-browser/recommended-practices/simulate-user-input-delay.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Heitor Tashiro Sergent <heitortsergent@gmail.com>
989d651
to
5a15396
Compare
What?
Add
sleep
andpage.waitForTimeout
doc to v0.52 & v0.53. It's a new recommended best practice doc for the browser module.Checklist
npm start
command locally and verified that the changes look good.docs/sources/next
folder of the documentation.docs/sources/v{most_recent_release}
folder of the documentation.Related PR(s)/Issue(s)
Updates: #1719