-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add draft for k6 new command docs #1860
Conversation
@dgzlopes added you as a reviewer as well since you worked on this feature. 🤓 One thing I don't love about this is the section where it's in... I think it makes sense to live under "Test authoring", but I don't like how that's buried three levels deep in the docs. One option, and something that @oleiade and I have been talking about, is maybe moving the "Test authoring" section all the way to the first level of the folder structure, next to "Set up" and "Using k6". Similar to how we have an "Author and run test" section in the GCk6 docs. What do you think? 🤔 |
@heitortsergent I think that's a good idea 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but please be aware that #1854 has been merged, so it's worth maybe to also reflecting along with next
changes under v0.57.x
Co-authored-by: Oleg Bespalov <oleg.bespalov@grafana.com>
Thanks for the reviews! I applied the changes to |
What?
Adds a new page explaining the k6
new
command and the new options available in k6 v0.57.Checklist
npm start
command locally and verified that the changes look good.docs/sources/k6/next
folder of the documentation.Related PR(s)/Issue(s)
Closes #1857.