Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add draft for k6 new command docs #1860

Merged
merged 5 commits into from
Feb 13, 2025
Merged

Add draft for k6 new command docs #1860

merged 5 commits into from
Feb 13, 2025

Conversation

heitortsergent
Copy link
Collaborator

What?

Adds a new page explaining the k6 new command and the new options available in k6 v0.57.

Checklist

  • I have used a meaningful title for the PR.
  • I have described the changes I've made in the "What?" section above.
  • I have performed a self-review of my changes.
  • I have run the npm start command locally and verified that the changes look good.
  • I have made my changes in the docs/sources/k6/next folder of the documentation.

Related PR(s)/Issue(s)

Closes #1857.

@heitortsergent heitortsergent requested a review from a team as a code owner February 11, 2025 20:33
@heitortsergent heitortsergent requested review from olegbespalov, joanlopez and dgzlopes and removed request for a team February 11, 2025 20:33
@heitortsergent
Copy link
Collaborator Author

@dgzlopes added you as a reviewer as well since you worked on this feature. 🤓

One thing I don't love about this is the section where it's in... I think it makes sense to live under "Test authoring", but I don't like how that's buried three levels deep in the docs.

One option, and something that @oleiade and I have been talking about, is maybe moving the "Test authoring" section all the way to the first level of the folder structure, next to "Set up" and "Using k6". Similar to how we have an "Author and run test" section in the GCk6 docs.

What do you think? 🤔

@dgzlopes
Copy link
Member

@heitortsergent I think that's a good idea 👍

Copy link
Member

@dgzlopes dgzlopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@olegbespalov olegbespalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but please be aware that #1854 has been merged, so it's worth maybe to also reflecting along with next changes under v0.57.x

@heitortsergent
Copy link
Collaborator Author

Thanks for the reviews! I applied the changes to v0.57.x. I'll go ahead and merge this so we have the k6 new docs out, and open a separate PR to reorganize the sections.

@heitortsergent heitortsergent merged commit 03fccbe into main Feb 13, 2025
3 checks passed
@heitortsergent heitortsergent deleted the hts/k6-new-command branch February 13, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create new page for k6 new command
3 participants