-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc scenario edits #936
Merged
Merged
Misc scenario edits #936
Changes from 13 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
9808150
scenarios, clean up arrival rate doc
MattDodsonEnglish d8c1b6f
Scenarios, clean up example text
MattDodsonEnglish 9d1753c
Scenario example, improve intro
MattDodsonEnglish aa09357
Add restricted comma phrase for smoother reading
MattDodsonEnglish a78d686
scenario example, shorten text
MattDodsonEnglish fe8c619
Scenario examples, language clean up
MattDodsonEnglish e64aaa9
Favor character over encoding
MattDodsonEnglish aa79e86
Delete redundant text and old reference
MattDodsonEnglish 18f5b76
Scenario examples, de-emphasize sequencing and composablilty
MattDodsonEnglish 4aae4e6
scenarios example, say "combine" instead of "sequence"
MattDodsonEnglish ea8a943
scenarios, language trimming
MattDodsonEnglish bfb7dcc
typo fix
MattDodsonEnglish 150d401
Update src/data/markdown/translated-guides/en/02 Using k6/14 Scenario…
MattDodsonEnglish 3c8c0f3
Scenario, more precise description
MattDodsonEnglish 79e817b
Formatting fixes
MattDodsonEnglish 2f0a52c
Improve description of splitting logic
MattDodsonEnglish a2d3c45
formatting fix
MattDodsonEnglish File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand what you mean here, sorry 😕 You can't have different
setup()
orteardown()
per scenario (see grafana/k6#1638, though it will probably be solved by actually implementing grafana/k6#1342)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see now it's not specific enough. Thanks for pointing it out. What about this?
About the strange terminology: a month ago we defined lifecycle function as
We changed "callbacks" to "lifecycle functions" because callback sounded like a JS callback. It wasn't so obvious that it was to the Go runtime. Discussion here: #845.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying to communicate what is done in this example, by the way.
Different scenarios run different VU logic.