Honoring scheme and bucket pathing #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
oleiade
approved these changes
May 5, 2023
There was a problem hiding this comment.
Great work @MarkCupitt 🎉
Thanks a lot for your contribution, much appreciated 🙇🏻
I've reviewed and tried the change, and everything seems to work as expected, although I haven't tried with Minio myself.
Merging 👏🏻
This was referenced May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#43
As promised, this is a quick and dirty fix .. to allow the scheme to work, I also fixed the bucket paths, to work with minio, putting them as bucket.url broke dns on everything except aws
Most of the libs I support provide this param which I think supports the bucket pathing I used
s3forcepathstyle: trueHave tested this on my local minio server, seems to work fine .. I would be confident you could say taht you supported minio if you wanted to with these fixes
Ill leave you to fix my mess and integrate it nicely, Im totally flat out, sorry
Feel free to ping me with any questions, happy to help out where I can