-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Kinesis #46
Conversation
✋🏻 We will need to have a documentation branch ready before we merge this ✋🏻 |
Hi @oleiade! I was looking precisely for this support and run into your PR. Thank you! Decided to give it a try but run into some issues I've been unable to fix. Sharing here in case it helps! The tests fail with the following error
I'm using Node.js v19.9.0 on an M1 MacBook. I see the tests are failing in the build system with the same message too (although the check is green?), so I'm guessing this is not something privy to my box. Can I help you debug this somehow? |
Hey @igracia 👋🏻 Thanks for taking this code out for a spin 🚗 Much appreciated! 👏🏻 We are actively looking into the errors you've reported, and I'll let you know if we could use some further support from you 🙇🏻 |
171deea
to
69156e6
Compare
@immavalls @igracia I have pushed some changes to the branch which address the issues related to the tests failing. It should at least work as intended on that front now 👍🏻 Could you please take it out for a spin and let me know if it works for you? 🙏🏻 🙇🏻 |
@oleiade It works for me now! I was having an issue with the I'm currently running this against a localstack v2.0.1 docker container. I'm setting up all my infra through docker compose, and the goal is to be able to run load tests locally in the same way as ew'd do in any other env, hence the liking for your plugin. |
LGTM! I'm having some issues with base64 encoding of protobuf data, but t's not related to this PR. Otherwise it's working great! |
This Pull Request is based on the excellent work done by @autometa101 in #33. It introduces support for a subset of the AWS Kinesis API.
All the credit goes to @autometa101 for this, as we only refactored, slightly changed a few APIs, documented, and reorganized the code in this PR.
@autometa101, if you have the time, I would appreciate it if you could take it for a spin and let us know if it works as intended 🙇🏻
closes #33