Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Event Bridge #55

Merged
merged 10 commits into from
Sep 28, 2023
Merged

Add support for Event Bridge #55

merged 10 commits into from
Sep 28, 2023

Conversation

jameshopkins
Copy link
Contributor

@jameshopkins jameshopkins commented Aug 11, 2023 •
edited
Loading

Adds support for Event Bridge PutEvents.

@jameshopkins jameshopkins marked this pull request as draft August 11, 2023 08:42
@CLAassistant
Copy link

CLAassistant commented Aug 11, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jameshopkins jameshopkins force-pushed the event-bridge-event-bus branch 2 times, most recently from 435bef1 to af2a90e Compare August 11, 2023 08:49
@jameshopkins jameshopkins marked this pull request as ready for review August 11, 2023 11:18
@oleiade oleiade self-requested a review August 14, 2023 12:48
@oleiade oleiade self-assigned this Aug 14, 2023
@oleiade oleiade added the enhancement New feature or request label Aug 14, 2023
oleiade
oleiade reviewed Aug 15, 2023
View reviewed changes
Copy link
Member

@oleiade oleiade left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @jameshopkins for your contribution, much appreciated 🎉 🙇🏻 Great work overall 👏🏻

I've left a couple of change requests that are just to align the code with our common practices and document it to make my life easier later on as I amend the k6 documentation.

src/internal/event-bridge.ts Outdated Show resolved Hide resolved
src/internal/event-bridge.ts Outdated Show resolved Hide resolved
src/internal/event-bridge.ts Outdated Show resolved Hide resolved
src/internal/event-bridge.ts Outdated Show resolved Hide resolved
@oleiade oleiade added this to the v0.10.0 milestone Aug 15, 2023
@oleiade
Copy link
Member

oleiade commented Sep 5, 2023

Hey @jameshopkins 👋🏻

Do you happen to have any updates on this? If you don't have the time or capacity, that's perfectly fine. please just let me know, and I will probably be able to address my comments myself 🙇🏻

@oleiade oleiade mentioned this pull request Sep 5, 2023
Closed
@jameshopkins
Copy link
Contributor Author

Hey @oleiade really sorry I haven’t got back re progress on this before now. Work has been pretty full-on.

would you mind addressing the comments if you’re able to? Sorry I wouldn’t normally do this but I have very little time right now

@oleiade
Copy link
Member

oleiade commented Sep 25, 2023

Sure thing, will address them indeed 👍🏻

@oleiade oleiade merged commit 58a329d into grafana:main Sep 28, 2023
@oleiade
Copy link
Member

oleiade commented Sep 28, 2023

I have modified the PR and merged it indeed. Thanks a lot for your contribution again 🎉

@oleiade oleiade mentioned this pull request Sep 28, 2023
Merged
@oleiade
Copy link
Member

oleiade commented Sep 28, 2023

I have created a PR for this in the documentation website's repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleiade oleiade oleiade left review comments

Assignees

@oleiade oleiade

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jameshopkins @CLAassistant @oleiade