Add support for Lambda #76

nickcaballero · 2023-11-01T20:38:17Z

This PR adds support for invoking Lambda functions.

nickcaballero · 2023-11-01T20:40:49Z

tests/internal/helpers.js

+    } catch (error) {
+        if (error.name !== 'AssertionError') {
+            console.error(`FAIL [${description}]`, error.stack);
+            check(error, {[description]: () => false})
+        } else {
+            console.error(`FAIL [${description}]`, error.message);
+        }
+    }


Adding this bit to provide better error messages. While testing I noticed that we weren't really adding a failed check when the test failed without any failed assertions.

I'm okay with this addition, albeit we might want to improve that generally eventually 👍🏻

Indeed asyncDescribe is pretty much a workaround (to not say hack) at the moment, as using k6-chaijs in an async context is currently impacted by k6#2728, and group not working correctly in an async context.

src/internal/error.ts

codebien

Hey @nickcaballero,
thanks for this new contribution! 🙇

We already have a similar PR #71 in the pipeline regarding the Lambda service. Our plan would be to merge #71 before then it would be great to have this PR rebased on top of it.
I see you have added additional details and a different proposal for the invoke API that we would like to include in the project.

Does it sound like a reasonable plan for you?

nickcaballero · 2023-11-02T13:13:43Z

Hey @nickcaballero, thanks for this new contribution! 🙇

We already have a similar PR #71 in the pipeline regarding the Lambda service. Our plan would be to merge #71 before then it would be great to have this PR rebased on top of it. I see you have added additional details and a different proposal for the invoke API that we would like to include in the project.

Does it sound like a reasonable plan for you?

Sounds good! Apologies, I didn't see the other PR 🤦.

codebien · 2023-11-02T16:51:36Z

Hey @nickcaballero, we merged #71. You can now rebase on top of it. Thanks for the effort 🙇

nickcaballero · 2023-11-02T17:53:11Z

src/internal/error.ts

+            const error = response.json() as any;
+            const message = error.Message || error.message || error.__type || 'An error occurred on the server side';
+            const code = response.headers['X-Amzn-Errortype'] || error.__type
+            return new AWSError(message, code)


Pulled some of the error handling logic that @jakub-qg added into here to make it more reusable.

This is really neat 🙇🏻

nickcaballero · 2023-11-02T17:54:06Z

Hey @nickcaballero, we merged #71. You can now rebase on top of it. Thanks for the effort 🙇

Done!

codebien · 2023-11-07T15:50:53Z

README.md

+Consult the `LambdaClient` [dedicated k6 documentation page](https://k6.io/docs/javascript-api/jslib/aws/lambdaclient) for more details on its methods and how to use it.
+
+```javascript
+import { AWSConfig, LambdaClient } from 'https://jslib.k6.io/aws/0.11.0/lambda.js'


Suggested change

import { AWSConfig, LambdaClient } from 'https://jslib.k6.io/aws/0.11.0/lambda.js'

import { AWSConfig, LambdaClient } from 'https://jslib.k6.io/aws/0.12.0/lambda.js'

I expect we need to bump, right @oleiade?

@codebien So far bumping version numbering has been part of our release process, and we haven't done it in feature PRs.

Although I realize we haven't added it to our CONTRIBUTING guidelines yet, will do so 👍🏻

codebien · 2023-11-07T15:53:58Z

localstack/init/ready.d/lambda.sh

+testdata_folder="/etc/localstack/init/testdata/lambda"
+zip_dir=/tmp/lambda
+mkdir -p "$zip_dir"

-# Create a dummy lambda function responding with a static string "Hello World!"
-cat >index.js <<EOF
-exports.handler = async function(event, context) {
-    return "Hello World!";
-}
-EOF
+for file in "$testdata_folder"/*; do
+  function_name=$(basename "$file")
+  function_zip="$zip_dir/$function_name.zip"
+  (cd "$file" || exit; zip "$function_zip" ./*)


@nickcaballero do we need to have them nested in folders? Could we have direct a list of files?

The file structure matches how the zips are created. We can flatten the folders, but it'll make the script a bit more complicated.

I would prefer to have a simpler script, rather than a simpler folder structure 👍🏻

oleiade

LGTM 👏🏻 🚀

Thank you for your contribution @nickcaballero, as always much appreciated 🙇🏻

oleiade · 2023-11-17T08:53:20Z

tests/internal/helpers.js

+    } catch (error) {
+        if (error.name !== 'AssertionError') {
+            console.error(`FAIL [${description}]`, error.stack);
+            check(error, {[description]: () => false})
+        } else {
+            console.error(`FAIL [${description}]`, error.message);
+        }
+    }


I'm okay with this addition, albeit we might want to improve that generally eventually 👍🏻

Indeed asyncDescribe is pretty much a workaround (to not say hack) at the moment, as using k6-chaijs in an async context is currently impacted by k6#2728, and group not working correctly in an async context.

oleiade · 2023-11-17T08:55:09Z

src/internal/error.ts

+            const error = response.json() as any;
+            const message = error.Message || error.message || error.__type || 'An error occurred on the server side';
+            const code = response.headers['X-Amzn-Errortype'] || error.__type
+            return new AWSError(message, code)


This is really neat 🙇🏻

oleiade · 2023-11-17T08:57:27Z

README.md

+Consult the `LambdaClient` [dedicated k6 documentation page](https://k6.io/docs/javascript-api/jslib/aws/lambdaclient) for more details on its methods and how to use it.
+
+```javascript
+import { AWSConfig, LambdaClient } from 'https://jslib.k6.io/aws/0.11.0/lambda.js'


@codebien So far bumping version numbering has been part of our release process, and we haven't done it in feature PRs.

Although I realize we haven't added it to our CONTRIBUTING guidelines yet, will do so 👍🏻

nickcaballero requested review from a team as code owners November 1, 2023 20:38

nickcaballero requested review from codebien, joanlopez, allansson and 2Steaks and removed request for a team November 1, 2023 20:38

nickcaballero commented Nov 1, 2023

View reviewed changes

codebien reviewed Nov 2, 2023

View reviewed changes

Add support for Lambda

0f8e8af

nickcaballero force-pushed the feat/lambda branch from a9445fc to 0f8e8af Compare November 2, 2023 17:50

nickcaballero commented Nov 2, 2023

View reviewed changes

allansson requested a review from codebien November 7, 2023 12:03

codebien reviewed Nov 7, 2023

View reviewed changes

codebien requested a review from oleiade November 15, 2023 13:40

2Steaks removed their request for review November 15, 2023 15:42

allansson removed their request for review November 15, 2023 20:33

oleiade approved these changes Nov 17, 2023

View reviewed changes

This was referenced Nov 17, 2023

Refactor client classes to make their properties private and readonly #79

Merged

Add missing release process steps #80

Merged

codebien approved these changes Nov 17, 2023

View reviewed changes

oleiade merged commit 6bf3253 into grafana:main Nov 17, 2023

joanlopez mentioned this pull request Jan 3, 2024

Add GitHub Workflow to automate release generation #89

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for Lambda #76

Add support for Lambda #76

nickcaballero commented Nov 1, 2023 •

edited

Loading

nickcaballero Nov 1, 2023

oleiade Nov 17, 2023

codebien left a comment

nickcaballero commented Nov 2, 2023

codebien commented Nov 2, 2023

nickcaballero Nov 2, 2023 •

edited

Loading

oleiade Nov 17, 2023

nickcaballero commented Nov 2, 2023

codebien Nov 7, 2023

oleiade Nov 17, 2023

codebien Nov 7, 2023

nickcaballero Nov 7, 2023

oleiade Nov 17, 2023

oleiade left a comment

oleiade Nov 17, 2023

oleiade Nov 17, 2023

oleiade Nov 17, 2023

	import { AWSConfig, LambdaClient } from 'https://jslib.k6.io/aws/0.11.0/lambda.js'
	import { AWSConfig, LambdaClient } from 'https://jslib.k6.io/aws/0.12.0/lambda.js'

Add support for Lambda #76

Add support for Lambda #76

Conversation

nickcaballero commented Nov 1, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codebien left a comment

Choose a reason for hiding this comment

nickcaballero commented Nov 2, 2023

codebien commented Nov 2, 2023

nickcaballero Nov 2, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nickcaballero commented Nov 2, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

oleiade left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nickcaballero commented Nov 1, 2023 •

edited

Loading

nickcaballero Nov 2, 2023 •

edited

Loading