-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module 3 review #18
Merged
Merged
Module 3 review #18
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
0904681
add some links and fix quizz format
immavalls 3bb82e7
fix broken links
immavalls 2c2a82a
fix quizz answers format
immavalls 33dbf04
update the example and minor format fixes
immavalls 9eb2d7d
fix quizz answers format and add title
immavalls ec3cdcd
move setup/teardown example to the teardown section and added some cl…
immavalls e5878e3
fix executors' link and add link to scenario options
immavalls 791064c
fix typo and format
immavalls 25da3f5
change question to grey
immavalls a0bd98b
change question to bulb
immavalls e8ef233
format change
immavalls b577757
minor fixes, add urls to the docs
immavalls 351750d
moved module III section 08 to root folder for the module to facilita…
immavalls e79ff07
change bulb to point_up
immavalls c9c6db2
fix typos and embedded video
immavalls c683435
fix typos and embedded video
immavalls f810cbf
minor format fixes
immavalls 89052e6
minor format fixes
immavalls 225ad9d
minor format & grammar fixes
immavalls 83fdf96
minor format & grammar fixes
immavalls 518b48a
minor format & grammar fixes
immavalls feeea91
minor format & grammar fixes
immavalls 21495e7
minor format & grammar fixes
immavalls 1b532a4
Apply suggestions from code review
immavalls File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the first place that CSFR appears? I think we might want to link it there, or not link unless it's necessary here. Generally, I try to avoid links in direct procedures, since links naturally call to themselves, which may divide the reader's attention.
Willing to change my opinion though if the info is particularly useful here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it was the first appearance, and for newcomers it's good to explain what this is (unless we had a glossary)