Arrival rate executors review #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before reviewing this, I'm going to wait for review comments on grafana/k6-docs#974 |
No rush, sounds good to wait on the doc changes before applying those here. Thanks @MattDodsonEnglish |
...I-k6-Intermediate/08-Setting-load-profiles-with-executors/Constant-Arrival-Rate-Exercises.md
Outdated
Show resolved
Hide resolved
...I-k6-Intermediate/08-Setting-load-profiles-with-executors/Constant-Arrival-Rate-Exercises.md
Outdated
Show resolved
Hide resolved
...I-k6-Intermediate/08-Setting-load-profiles-with-executors/Constant-Arrival-Rate-Exercises.md
Outdated
Show resolved
Hide resolved
...I-k6-Intermediate/08-Setting-load-profiles-with-executors/Constant-Arrival-Rate-Exercises.md
Outdated
Show resolved
Hide resolved
...I-k6-Intermediate/08-Setting-load-profiles-with-executors/Constant-Arrival-Rate-Exercises.md
Outdated
Show resolved
Hide resolved
...I-k6-Intermediate/08-Setting-load-profiles-with-executors/Constant-Arrival-Rate-Exercises.md
Outdated
Show resolved
Hide resolved
...I-k6-Intermediate/08-Setting-load-profiles-with-executors/Constant-Arrival-Rate-Exercises.md
Outdated
Show resolved
Hide resolved
...I-k6-Intermediate/08-Setting-load-profiles-with-executors/Constant-Arrival-Rate-Exercises.md
Outdated
Show resolved
Hide resolved
...I-k6-Intermediate/08-Setting-load-profiles-with-executors/Constant-Arrival-Rate-Exercises.md
Outdated
Show resolved
Hide resolved
...II-k6-Intermediate/08-Setting-load-profiles-with-executors/Ramping-Arrival-Rate-Exercises.md
Outdated
Show resolved
Hide resolved
...II-k6-Intermediate/08-Setting-load-profiles-with-executors/Ramping-Arrival-Rate-Exercises.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Matt Dodson <47385188+MattDodsonEnglish@users.noreply.github.com>
|
@javaducky I'd appreciate your review (not urgent). @MattDodsonEnglish already updated the docs, see https://k6.io/docs/using-k6/scenarios/concepts/ and mostly https://k6.io/docs/using-k6/scenarios/concepts/arrival-rate-vu-allocation/. Thanks! |
javaducky
approved these changes
Jan 18, 2023
...II-k6-Intermediate/08-Setting-load-profiles-with-executors/Ramping-Arrival-Rate-Exercises.md
Outdated
Show resolved
Hide resolved
|
|
||
| Restating once again, the _Ramping Arrival Rate_ executor is focused on the _iteration rate_ over a period of time within stages. k6 aims to eliminate the need to be overly concerned about the actual number of users required to achieve such a rate. As a user of the executor, our script can simply specify the maximum number of VUs allowed, letting k6 handle the actual details. This can be referred to as _autoscaling_. | ||
| From our example above, we have that our request duration or latency is, on average, 116.57ms, and the 95 percentile is around 151.35ms. With just 2 VUs (`preAllocatedVUs`), in a very optimistic scenario, we cannot expect much more than `2 VUs / 0.116 s = 17.24 iterations/s`. Even if this was the only factor at play, which we see is not in the next section. |
There was a problem hiding this comment.
From our example above, we have that our request duration or latency is, on average
The "request duration or latency is" part feels like it should be "request duration--or latency--is." 🤷
Even if this was the only factor at play, which we see is not in the next section.
This sentence seems incomplete.
Co-authored-by: Paul Balogh <javaducky@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review to remove the recommendations to use
maxVUswhen using constant arrival rate and ramping arrival rate executors.It's usually best to pre-allocate all VUs (and let
maxVUstake its default valuepreAllocatedVUs).