Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ability to set the environment variables with envFrom in k6 runner/starter. #129

Merged
merged 2 commits into from
Jul 18, 2022
Merged

feat: ability to set the environment variables with envFrom in k6 runner/starter. #129

merged 2 commits into from
Jul 18, 2022

Conversation

mugioka
Copy link
Contributor

@mugioka mugioka commented Jul 15, 2022

Closes #122.

yorugac
yorugac requested changes Jul 15, 2022
View reviewed changes
Copy link
Collaborator

@yorugac yorugac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mugioka Thanks for the PR! It LGTM 👍 I'll run a couple of tests but should be good to merge. Please see there is a small request change.

config/crd/bases/k6.io_k6s.yaml Show resolved Hide resolved
yorugac
yorugac approved these changes Jul 18, 2022
View reviewed changes
Copy link
Collaborator

@yorugac yorugac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished testing: seems to be fine. Thanks again!

There's a potential caveat around Envoy vars but it should be fine as env should have a higher priority than envFrom.

@yorugac yorugac merged commit 3618c4b into grafana:main Jul 18, 2022
@mugioka mugioka deleted the feat/ability-to-set-environment-variables-with-env-from-in-k6-runner-starter branch July 18, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yorugac yorugac yorugac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: can be set environment variable from envFrom in k6 CR.
2 participants
@mugioka @yorugac