-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use name instead of index for instance id tag #135
Conversation
Hi @spoukke, |
Yes, it would work, I am going to do the modification! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Thank you @spoukke!
But not the unit tests, apparently: https://github.com/grafana/k6-operator/runs/7917488949?check_suite_focus=true |
Hi @yorugac ! Just updated the unit tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@spoukke Thanks for following up with this! Merging in now.
Currently, the tag used for instance id is the index of the job. But, if you run multiple K6 resources at the same time, there is no way to distinguish them.
Here I propose to use the name of the job, instead of the index of the job