Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates README and adds an example for volumeClaim testing usage #151

Merged
merged 2 commits into from
Aug 31, 2022

Conversation

ionicc
Copy link
Contributor

@ionicc ionicc commented Aug 28, 2022

What does this PR do?

  • Adds a volumeClaim example: config/samples/k6_v1alpha1_k6_with_volumeClaim.yaml.
  • Updates the readme with a more thorough explanation on how to use volumeClaims and also adds a directory example.

Why?

  • After taking some time debugging and experimenting with running k6 tests using volumeClaims, I believe having more concrete examples and explanations like this would help folks working with it in the future.

@CLAassistant
Copy link

CLAassistant commented Aug 28, 2022

CLA assistant check
All committers have signed the CLA.

@ionicc ionicc changed the title Feat: Add more information on how to use volumeClaim testing in the r… Updates README and adds an example for volumeClaim testing usage Aug 28, 2022
…eadme along with an example in config/samples

Signed-off-by: Sagar Vakkala <sagarwakawaka@gmail.com>
@ionicc ionicc force-pushed the volumeClaim-readme-and-example branch from 331c09a to 3c0dd25 Compare August 28, 2022 04:11
Copy link
Collaborator

@yorugac yorugac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ionicc Thank you a lot for this PR! No doubt that it'll definitely be helpful 👍 😄

I have a bit of change request; could you please update it?

Comment on lines 15 to 16
runner:
image: <custom-image>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Custom image is not a requirement for volumeClaim: could you please remove it from the example? So that there's no confusion about it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yorugac Thanks for noticing that, Removed it now!

README.md Outdated
│ │ ├── stress-test.js
│ ├── test.js
```
In the above example, `test.js` imports a function from `stress-test.js` and, They would look like this:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In the above example, `test.js` imports a function from `stress-test.js` and, They would look like this:
In the above example, `test.js` imports a function from `stress-test.js` and they would look like this:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yorugac Nicely observed, Fixed!

Signed-off-by: Sagar Vakkala <sagarwakawaka@gmail.com>
@ionicc ionicc requested a review from yorugac August 29, 2022 16:13
Copy link
Collaborator

@yorugac yorugac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ionicc Great, thanks for the update!

@yorugac yorugac merged commit 25e028e into grafana:main Aug 31, 2022
@patenvy1234
Copy link

how to create a volume claim pls explain

@yorugac
Copy link
Collaborator

yorugac commented Jun 14, 2023

@patenvy1234, creating volumes and volume claims is part of standard Kubernetes docs:
https://kubernetes.io/docs/tasks/configure-pod-container/configure-persistent-volume-storage/#create-a-persistentvolume
There're also a lot of third-party guides and howto's in the network about it.

@patenvy1234
Copy link

I am using --out csv option as an arugment to get csv output from each pod but as the pods are unaccessible I am not able to get those CSV outputs will PVC help me here or is there any other simpler option ?

@patenvy1234
Copy link

I have already created volume claim now how store the test.js inside it ? and what should be the mounting location

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants