-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates README and adds an example for volumeClaim testing usage #151
Conversation
…eadme along with an example in config/samples Signed-off-by: Sagar Vakkala <sagarwakawaka@gmail.com>
331c09a
to
3c0dd25
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ionicc Thank you a lot for this PR! No doubt that it'll definitely be helpful 👍 😄
I have a bit of change request; could you please update it?
runner: | ||
image: <custom-image> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Custom image is not a requirement for volumeClaim
: could you please remove it from the example? So that there's no confusion about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yorugac Thanks for noticing that, Removed it now!
README.md
Outdated
│ │ ├── stress-test.js | ||
│ ├── test.js | ||
``` | ||
In the above example, `test.js` imports a function from `stress-test.js` and, They would look like this: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the above example, `test.js` imports a function from `stress-test.js` and, They would look like this: | |
In the above example, `test.js` imports a function from `stress-test.js` and they would look like this: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yorugac Nicely observed, Fixed!
Signed-off-by: Sagar Vakkala <sagarwakawaka@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ionicc Great, thanks for the update!
how to create a volume claim pls explain |
@patenvy1234, creating volumes and volume claims is part of standard Kubernetes docs: |
I am using --out csv option as an arugment to get csv output from each pod but as the pods are unaccessible I am not able to get those CSV outputs will PVC help me here or is there any other simpler option ? |
I have already created volume claim now how store the test.js inside it ? and what should be the mounting location |
What does this PR do?
config/samples/k6_v1alpha1_k6_with_volumeClaim.yaml
.Why?