Added support for imagePullPolicy #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @cmerge1, Thank you for opening PR! Apologies for the delay but could you please update the branch with the latest main ( |
cmergenthaler
force-pushed
the
support-imagepullpolicy
branch
from
310ebcd
to
f0e001f
Compare
|
Done |
yorugac
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to configure ImagePullPolicy for runner and starter specs in K6-CRD.
By default k8s uses IfNotPresent policy for image pulling (except for :latest tags which in this case is Always).
I've also adjusted tests for runner, starter and initializer to check imagePullPolicy.
Closes #152