Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README memory limit resources typo #158

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Conversation

paulomf
Copy link
Contributor

@paulomf paulomf commented Oct 23, 2022

Current documentation provides an invalid value for memory limit.

The K6 "k6-sample-1" is invalid: spec.runner.resources.limits.memory: Invalid value: "1000mi": spec.runner.resources.limits.memory in body should match '^(\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))(([KMGTPE]i)|[numkMGTPE]|([eE](\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))))?$'

Current documentation provides an invalid value for memory limit.

The K6 "k6-sample-21" is invalid: spec.runner.resources.limits.memory: Invalid value: "1000mi": spec.runner.resources.limits.memory in body should match '^(\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))(([KMGTPE]i)|[numkMGTPE]|([eE](\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))))?$'
@CLAassistant
Copy link

CLAassistant commented Oct 23, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@yorugac yorugac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulomf Thank you for spotting and fixing this!

@yorugac yorugac merged commit 6117d20 into grafana:main Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants