Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add initializer envFrom field #351

Merged
merged 2 commits into from
Dec 12, 2023
Merged

feat: add initializer envFrom field #351

merged 2 commits into from
Dec 12, 2023

Conversation

ghostx31
Copy link
Contributor

@ghostx31 ghostx31 commented Dec 8, 2023

As discussed, this is a very small PR adding the envFrom field for initializer and should fix #348

This is my first time going through the k6-operator source code so if I missed anything (helm chart version bump or test cases in initializer_test.go) then let me know.

@CLAassistant
Copy link

CLAassistant commented Dec 8, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@yorugac yorugac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ghostx31. Yes, please add the EnvFrom to structs in the TestNewInitializerJob (initializer_test.go).

@ghostx31
Copy link
Contributor Author

I've added the the test case for initializer and tested them with make test as well @yorugac

Copy link
Collaborator

@yorugac yorugac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ghostx31 Thanks for the update 🙌

@yorugac yorugac merged commit 1d97a47 into grafana:main Dec 12, 2023
6 checks passed
@ghostx31 ghostx31 deleted the ft/initializer-envfrom branch December 13, 2023 10:08
@yorugac yorugac added this to the 0.13 milestone Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The initializer pod spec does not have envFrom
3 participants