add filters and warning and action to add rule

grafana · Sep 20, 2024 · ea0fa23 · ea0fa23
1 parent c8a024a
commit ea0fa23
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 5 deletions.
diff --git a/src/views/Generator/NewRuleMenu.tsx b/src/views/Generator/NewRuleMenu.tsx
@@ -27,14 +27,21 @@ export function NewRuleMenu() {
             createRule('correlation')
           }}
         >
-          Correlation rule
+          Correlation
         </DropdownMenu.Item>
         <DropdownMenu.Item
           onClick={() => {
             createRule('customCode')
           }}
         >
-          Custom code rule
+          Custom code
+        </DropdownMenu.Item>
+        <DropdownMenu.Item
+          onClick={() => {
+            createRule('verification')
+          }}
+        >
+          Verification (limited)
         </DropdownMenu.Item>
       </DropdownMenu.Content>
     </DropdownMenu.Root>

diff --git a/src/views/Generator/TestRuleContainer/TestRule/TestRuleInlineContent.tsx b/src/views/Generator/TestRuleContainer/TestRule/TestRuleInlineContent.tsx
@@ -1,4 +1,9 @@
-import { CorrelationRule, CustomCodeRule, TestRule } from '@/types/rules'
+import {
+  CorrelationRule,
+  CustomCodeRule,
+  TestRule,
+  VerificationRule,
+} from '@/types/rules'
 import { TestRuleFilter } from './TestRuleFilter'
 import { Badge, Tooltip } from '@radix-ui/themes'
 import { exhaustive } from '@/utils/typescript'
@@ -8,6 +13,7 @@ import {
   BorderRightIcon,
   EyeOpenIcon,
   DiscIcon,
+  ExclamationTriangleIcon,
 } from '@radix-ui/react-icons'
 
 interface TestRuleInlineContentProps {
@@ -21,23 +27,32 @@ export function TestRuleInlineContent({ rule }: TestRuleInlineContentProps) {
     case 'customCode':
       return <CustomCodeContent rule={rule} />
     case 'parameterization':
+      return null
     case 'verification':
-      return <VerificationContent />
+      return <VerificationContent rule={rule} />
     default:
       return exhaustive(rule)
   }
 }
 
-function VerificationContent() {
+function VerificationContent({ rule }: { rule: VerificationRule }) {
   return (
     <>
+      <TestRuleFilter filter={rule.filter} />{' '}
       <Tooltip
         content={`Checks will be added for status to be the same as the recording.`}
       >
         <Badge color="gray">
           <DiscIcon /> Recording
         </Badge>
       </Tooltip>
+      <Tooltip
+        content={`Only have a single Verification rule per generator, this is still a work in progress.`}
+      >
+        <Badge color="orange">
+          <ExclamationTriangleIcon />
+        </Badge>
+      </Tooltip>
     </>
   )
 }