feat: Improve group creation #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-fisher
requested review from
allansson,
going-confetti,
cristianoventura and
Llandy3d
e-fisher
commented
Sep 20, 2024
| useClickAway(headerRef, () => { | ||
| if (!group.isEditing) return | ||
|
|
||
| handleSubmit(submit)() | ||
| }) |
There was a problem hiding this comment.
This custom hook would cause a race condition and disable edit mode when clicking on "add group" button, replacing it with the hook from react-use seems to solve the problem.
Llandy3d
approved these changes
Sep 20, 2024
going-confetti
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to improve group creation during recording.
Potential future improvements:
CleanShot.2024-09-19.at.14.45.12.mp4