fix: set cookies only on correlation #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-fisher
reviewed
Sep 20, 2024
There was a problem hiding this comment.
Just to clarify, if we pass cookies = {} then k6 executable will handle cookies automatically?
I've also done some testing with correlation rule on test.k6.io, looks like it no longer sets cookies even when correlation rule matches, attaching har and generator:
Nice catch! I pushed a fix and a new test case Regarding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were setting cookies regardless if they were correlated or not. That should be handled by k6 so now we only actually set cookies if they have a correlation value