feat: add contrast to editor in light theme #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
going-confetti
previously approved these changes
Sep 20, 2024
There was a problem hiding this comment.
This should be a regular .ts file
There was a problem hiding this comment.
oops 🙈 Fixed!
cristianoventura
dismissed stale reviews from going-confetti, e-fisher, and Llandy3d
via
4cc49c4
Llandy3d
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the background color of the Monaco Editor and JSON view in light mode, to give some contrast compared to the background of the app, similar to when in dark mode.
JSON content:
JSON preview:
Custom code:
Script:
