Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Splashscreen logo broken in build #230

Merged
merged 3 commits into from
Sep 27, 2024
Merged

fix: Splashscreen logo broken in build #230

merged 3 commits into from
Sep 27, 2024

Conversation

e-fisher
Copy link
Collaborator

@e-fisher e-fisher commented Sep 27, 2024 •
edited
Loading

Description

Fixes splashscreen logo not being displayed in production builds.

How to Test

I've built 0.2.0 draft from this PR, to test:

  • Download and install 0.2.0 app
  • Verify splashscreen logo is displayed

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (npm run lint) and all checks pass.
  • I have run tests locally (npm test) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Screenshots (if appropriate):

CleanShot 2024-09-27 at 11 12 01

Related PR(s)/Issue(s)

@e-fisher e-fisher marked this pull request as ready for review September 27, 2024 08:12
@e-fisher e-fisher requested a review from a team as a code owner September 27, 2024 08:12
@e-fisher e-fisher requested review from cristianoventura and Llandy3d and removed request for a team September 27, 2024 08:12
Llandy3d
Llandy3d approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@Llandy3d Llandy3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@e-fisher e-fisher merged commit f454324 into main Sep 27, 2024
4 checks passed
@e-fisher e-fisher deleted the fix/splashscreen-image branch September 27, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Llandy3d Llandy3d Llandy3d approved these changes

@cristianoventura cristianoventura Awaiting requested review from cristianoventura cristianoventura is a code owner automatically assigned from grafana/k6-studio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@e-fisher @Llandy3d