fix: Show allowlist dialog as modal when action is required #292
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've recently updated allowlist dialog to be displayed as an inline popover to match test options' dialog style. Although this approach is effective, we would like to direct the user's attention towards the allowlist when the user's input is required. This includes when creating a new generator, opening a generator without a set allowlist, or switching between recordings that contain different hosts. With this change, allowlist could be displayed both as popover or modal depending on this condition:
If allowlist is triggered by indirect action (open generator, switch recording) → show as modal.
If allowlist button is clicked inside generator → show as popover.
Could use some feedback whether we should disable "Continue" button when no hosts are selected. Currently, it's not blocking you from continuing without any hosts because neither does the allowlist popover.
How to Test
Verify allowlist is displayed as a popover when clicking the allowlist button, and as modal in other cases.
Checklist
npm run lint
) and all checks pass.npm test
) and all tests pass.Screenshots (if appropriate):
Related PR(s)/Issue(s)