Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Show allowlist dialog as modal when action is required #292

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

e-fisher
Copy link
Collaborator

Description

We've recently updated allowlist dialog to be displayed as an inline popover to match test options' dialog style. Although this approach is effective, we would like to direct the user's attention towards the allowlist when the user's input is required. This includes when creating a new generator, opening a generator without a set allowlist, or switching between recordings that contain different hosts. With this change, allowlist could be displayed both as popover or modal depending on this condition:

If allowlist is triggered by indirect action (open generator, switch recording) → show as modal.
If allowlist button is clicked inside generator → show as popover.

Could use some feedback whether we should disable "Continue" button when no hosts are selected. Currently, it's not blocking you from continuing without any hosts because neither does the allowlist popover.

How to Test

Verify allowlist is displayed as a popover when clicking the allowlist button, and as modal in other cases.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (npm run lint) and all checks pass.
  • I have run tests locally (npm test) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Screenshots (if appropriate):

CleanShot 2024-10-30 at 16 17 31

CleanShot 2024-10-30 at 16 17 43

Related PR(s)/Issue(s)

@e-fisher e-fisher requested a review from a team as a code owner October 30, 2024 14:20
@e-fisher e-fisher requested review from going-confetti and Llandy3d and removed request for a team October 30, 2024 14:20
Copy link
Member

@Llandy3d Llandy3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀

Could use some feedback whether we should disable "Continue" button when no hosts are selected. Currently, it's not blocking you from continuing without any hosts because neither does the allowlist popover.

Personally I think it's fine, the continue is there to go to the next step. It's true that it doesn't make too much sense to proceed with no host selected but the user is not locked out, they can still select the host from the popover. So overall for this PR I think it's fine 🙌

@e-fisher e-fisher merged commit e1dd857 into main Oct 31, 2024
2 checks passed
@e-fisher e-fisher deleted the fix/show-allowlist-as-modal-or-popover branch October 31, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants