feat: prompt to save generator on exit #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+20
to
+22
| useEffect(() => { | ||
| window.studio.app.changeRoute(location.pathname) | ||
| }, [location]) |
There was a problem hiding this comment.
I'm keeping track of the routes on the electron side so we know which route the close event in the main window came from.
cristianoventura
requested review from
going-confetti,
e-fisher and
Llandy3d
and removed request for
a team
Llandy3d
previously approved these changes
Oct 30, 2024
going-confetti
previously approved these changes
Oct 30, 2024
|
what about the same text plus It should work both for leaving the page and leaving the application! |
cristianoventura
dismissed stale reviews from going-confetti and Llandy3d
via
5c7399c
|
@Llandy3d I liked your suggestion. Just pushed a change with it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR triggers the dialog to save the generator (if unsaved changes are present) when closing the main window.
How to Test
Checklist
npm run lint) and all checks pass.npm test) and all tests pass.Screenshots (if appropriate):
Screen.Recording.2024-10-30.at.10.18.57.AM.mov
Related PR(s)/Issue(s)
Resolves #239