feat: Persistent theme settings #347
Conversation
going-confetti
requested review from
cristianoventura and
e-fisher
and removed request for
a team
There was a problem hiding this comment.
Oh man, I loved that switch in activity bar 😞 It removes the friction to test both themes when developing, can we keep it in activity bar additionally to settings? We could also wrap in dev mode condition if there's a reason we don't want to have it there in prod builds.
Let's make it dev-only for now 👍 |
src/components/ThemeSwitcher.tsx
Outdated
| @@ -4,6 +4,12 @@ import { IconButton, Tooltip } from '@radix-ui/themes' | |||
|
|
|||
| export function ThemeSwitcher() { | |||
| const theme = useTheme() | |||
| // @ts-expect-error we have commonjs set as module option | |||
| const isDev = import.meta.env.DEV | |||
There was a problem hiding this comment.
Would process.env.NODE_ENV === 'development' work here to prevent @ts-expect-error?
There was a problem hiding this comment.
Thanks for the suggestion. I was under the impression it wasn't available in the render process 👀. Replaced with process.env.NODE_ENV === 'development' 👍
Description
How to Test
Checklist
npm run lint) and all checks pass.npm test) and all tests pass.Screenshots (if appropriate):
Related PR(s)/Issue(s)