Skip to content

Commit

Permalink
Improve the code comments for obsolete Engine tests
Browse files Browse the repository at this point in the history
  • Loading branch information
na-- committed Dec 5, 2022
1 parent f18a3be commit 3e73e87
Showing 1 changed file with 12 additions and 6 deletions.
18 changes: 12 additions & 6 deletions core/engine_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -720,7 +720,8 @@ func TestSentReceivedMetrics(t *testing.T) {
})
}

// TODO: delete, functionality duplicated in cmd/integration_test.go
// TODO: delete when implementing https://github.com/grafana/k6/issues/1889, the
// test functionality was duplicated in cmd/integration_test.go
func TestRunTags(t *testing.T) {
t.Parallel()

Expand Down Expand Up @@ -841,7 +842,8 @@ func TestRunTags(t *testing.T) {
}
}

// TODO: delete, functionality duplicated in cmd/integration_test.go
// TODO: delete when implementing https://github.com/grafana/k6/issues/1889, the
// test functionality was duplicated in cmd/integration_test.go
func TestSetupException(t *testing.T) {
t.Parallel()

Expand Down Expand Up @@ -894,7 +896,8 @@ func TestSetupException(t *testing.T) {
}
}

// TODO: delete, functionality duplicated in cmd/integration_test.go
// TODO: delete when implementing https://github.com/grafana/k6/issues/1889, the
// test functionality was duplicated in cmd/integration_test.go
func TestVuInitException(t *testing.T) {
t.Parallel()

Expand Down Expand Up @@ -1111,7 +1114,8 @@ func TestMetricsEmission(t *testing.T) {
}
}

// TODO: delete, functionality duplicated in cmd/integration_test.go
// TODO: delete when implementing https://github.com/grafana/k6/issues/1889, the
// test functionality was duplicated in cmd/integration_test.go
func TestMinIterationDurationInSetupTeardownStage(t *testing.T) {
t.Parallel()
setupScript := `
Expand Down Expand Up @@ -1192,7 +1196,8 @@ func TestMinIterationDurationInSetupTeardownStage(t *testing.T) {
}
}

// TODO: delete, functionality duplicated in cmd/integration_test.go
// TODO: delete when implementing https://github.com/grafana/k6/issues/1889, the
// test functionality was duplicated in cmd/integration_test.go
func TestEngineRunsTeardownEvenAfterTestRunIsAborted(t *testing.T) {
t.Parallel()

Expand Down Expand Up @@ -1236,7 +1241,8 @@ func TestEngineRunsTeardownEvenAfterTestRunIsAborted(t *testing.T) {
assert.Equal(t, 1.0, count)
}

// TODO: delete, functionality duplicated in cmd/integration_test.go
// TODO: delete when implementing https://github.com/grafana/k6/issues/1889, the
// test functionality was duplicated in cmd/integration_test.go
func TestActiveVUsCount(t *testing.T) {
t.Parallel()

Expand Down

0 comments on commit 3e73e87

Please sign in to comment.