Update the linter and fix linter issues

grafana · May 21, 2020 · 473f934 · 473f934
1 parent 6e4ea20
commit 473f934
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 3 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -26,7 +26,7 @@ jobs:
       - image: circleci/golang:1.14
     environment:
       GOPATH: /home/circleci/.go_workspace
-      GOLANGCI_VERSION: v1.25.0
+      GOLANGCI_VERSION: v1.27.0
     working_directory: /home/circleci/.go_workspace/src/github.com/loadimpact/k6
     steps:
       # Workaround for custom env vars not available in cache keys

diff --git a/.golangci.yml b/.golangci.yml
@@ -58,4 +58,5 @@ linters:
   - testpackage
   - wsl
   - gomnd
+  - goerr113 # most of the errors here are meant for humans
   fast: false
diff --git a/core/local/local_test.go b/core/local/local_test.go
@@ -53,7 +53,7 @@ import (
 )
 
 func newTestExecutionScheduler(
-	t *testing.T, runner lib.Runner, logger *logrus.Logger, opts lib.Options, //nolint: golint
+	t *testing.T, runner lib.Runner, logger *logrus.Logger, opts lib.Options,
 ) (ctx context.Context, cancel func(), execScheduler *ExecutionScheduler, samples chan stats.SampleContainer) {
 	if runner == nil {
 		runner = &minirunner.MiniRunner{}

diff --git a/lib/executor/executors_test.go b/lib/executor/executors_test.go
@@ -44,7 +44,7 @@ type configMapTestCase struct {
 	expected exp
 }
 
-//nolint:lll,gochecknoglobals
+//nolint:gochecknoglobals
 var configMapTestCases = []configMapTestCase{
 	{"", exp{parseError: true}},
 	{"1234", exp{parseError: true}},