Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the usage report #1301

Closed
na-- opened this issue Jan 8, 2020 · 0 comments
Closed

Fix the usage report #1301

na-- opened this issue Jan 8, 2020 · 0 comments
Assignees
@imiric
Labels
bug executors lower prio

Comments

@na--
Copy link
Member

na-- commented Jan 8, 2020

The usage report in #1007 is currently broken and disabled. Because we want to maximally preserve user privacy and not send any potentially sensitive data, we can't just package the new execution option and send that, since it could contain sensitive data we don't want to know.

Instead, we need to move the sending of the usage report from before the start of the script to the end of the execution and send only a rough summary of what was actually executed. So:

  • the k6_version, goos and goarch JSON fields remain unchanged
  • vus_max, iterations and duration would get their values from the ExecutionState
  • st_duration will be removed, since it doesn't make a lot of sense
  • we might want to also add a field for the used executor types, but only their types and number, no names or any other details
@na-- na-- mentioned this issue Mar 3, 2020
Closed
@imiric imiric self-assigned this Mar 4, 2020
imiric pushed a commit that referenced this issue Mar 4, 2020
Re-enable the usage report
438ba30 
Closes #1301
@imiric imiric mentioned this issue Mar 4, 2020
Merged
imiric pushed a commit that referenced this issue Mar 11, 2020
Re-enable the usage report (#1343)
89c0e4c 
* Re-enable the usage report

Closes #1301

* Sync usage report goroutine with WaitGroup

Resolves #1343 (comment)

* Add initialized VUs count to usage report

Partly resolves #1343 (comment)

* Use full version in usage report

Resolves #1343 (comment)

* Latest changes from code review (will squash)

* Fix nil pointer panic if timeout is reached

* Use channel to sync reportUsage goroutine

Resolves #1343 (comment)

* Fix: only wait for report ch if it wasn't disabled
@imiric imiric closed this as completed Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@imiric imiric

Labels
bug executors lower prio
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@imiric @na--