Ability to specify timeouts

[robingustafsson]

Being able to specify TCP connection and HTTP send/receive timeouts is important for simulating different types of clients and conditions.

I think we should add both global and local timeout options. Global options could be specified either in the "options" or using an API like options.set("tcp.connection_timeout", "100ms").

Local options could be specified at the HTTP request call site, something like http.get("http://example.com/", null, { "http.rw_timeout": "1s" }).

The cascading of the options would be options <- options API <- http API param

[martinfijal]

Also make sure we have proper defaults in place now

[robingustafsson]

@martinfijal What is a proper default? I'm guessing you're referring to rload's default of 120s as improper 😄 Are there other tools, libs, browsers we should look at to get some kind of common default or do you have a specific number in mind?

[martinfijal]

Unlike how rload works, I'd like one timeout for connect and one for data. I'm even happy with a hard timeout that ignores whether we are still receiving data or not (like rload), as long as it can be overridden to a higher number. 120s is good starting point :)

[robingustafsson]

Ah right, I'd forgotten the default is shared between connect and r/w timeouts in rload (they're overridable separately though). I'd imagine it's common to have the connect timeout shorter than the r/w timeout by default?

[liclac]

Gimme some defaults and I'll make this happen. (I'd personally go for only a request timeout to keep it simple, but that's just me.)

[martinfijal]

My suggestion as a start: Connection timeout: 60s and Read/write timeout: 120s.