Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize TestRealTimeAndSetupTeardownMetrics on windows/appveyor #919

Closed
mstoykov opened this issue Feb 4, 2019 · 2 comments
Closed

Stabilize TestRealTimeAndSetupTeardownMetrics on windows/appveyor #919

mstoykov opened this issue Feb 4, 2019 · 2 comments

Comments

@mstoykov
Copy link
Contributor

mstoykov commented Feb 4, 2019

Currently this test is failing more than 50% of the time because of timings. This might be because some specifics on windows or just appveyor doesn't give us enough CPU time to finish the tests consistently. Either way the constant failing is annoying and is getting in the way of developing by making us constantly rerunning the tests.

@na--
Copy link
Member

na-- commented Feb 13, 2019

I can think of only one way to avoid using timings in this test - by using long-running HTTP requests. That way we can synchronize the JS and Go code of the tests - the HTTP server on the Go side can delay responding to the JS HTTP requests until it reads some required metrics from the metrics output channel. That way we can verify that they're actually sent in real time, and not at the end of the iteration.

@mstoykov
Copy link
Contributor Author

mstoykov commented Oct 6, 2023

This seems to have been fixed - probably due to appveyor swap of github actions ... maybe not.

But it is no longer happening in my experience so closing

@mstoykov mstoykov closed this as completed Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants