fix(ws): return error before running setup fn if WS is not connectable #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1127 +/- ##
==========================================
+ Coverage 73.33% 73.35% +0.01%
==========================================
Files 141 141
Lines 10305 10305
==========================================
+ Hits 7557 7559 +2
+ Misses 2304 2303 -1
+ Partials 444 443 -1
Continue to review full report at Codecov.
|
cuonglm
previously approved these changes
Aug 27, 2019
na--
previously approved these changes
Aug 28, 2019
imiric
force-pushed
the
fix/1116-ws-message-send-panic
branch
from
438720f to
9059dbc
Compare
imiric
force-pushed
the
fix/1116-ws-message-send-panic
branch
from
9059dbc to
20d1d5a
Compare
na--
approved these changes
Aug 29, 2019
mstoykov
added a commit
that referenced
this pull request
Jan 10, 2022
There are no handlers to be made in that case. Arguably prior to PR #1127 that could've been possible but not anymore, so it's just a noop either way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very naive fix for #1116: it ensures the WS connection is established before running the setup function.
This avoids the panic and running the test script provided by @mstoykov now outputs:
Closes #1116