fix(js): fail check if an error is thrown #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1137 +/- ##
==========================================
+ Coverage 73.58% 73.59% +0.01%
==========================================
Files 144 144
Lines 10527 10531 +4
==========================================
+ Hits 7746 7750 +4
Misses 2323 2323
Partials 458 458
Continue to review full report at Codecov.
|
cuonglm
reviewed
Sep 3, 2019
imiric
force-pushed
the
fix/1054-fail-check-on-exception
branch
from
c3fc860 to
af0b23d
Compare
na--
requested changes
Sep 3, 2019
na--
previously approved these changes
Sep 3, 2019
imiric
force-pushed
the
fix/1054-fail-check-on-exception
branch
from
af0b23d to
35043fd
Compare
na--
approved these changes
Sep 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix ensures the check metric is failed if an error occurs inside the check function, while still allowing an unhandled error to be thrown and interrupt the test, keeping backwards compatibility.
Closes #1054