Prefix all envconfig struct tags with K6 directly #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Works on #671 and fixing it in almost all cases. This was done primarily by running: ``` rg -g "*.go" 'envconfig:"' --files-with-matches |\ xargs -n 1 sed -s -i 's/envconfig:"/envconfig:"K6_/g' ``` And than manually fixing all remaing problems by hand. In the mean time I found out we weren't properly combing the configuration for statsd/datadog and fixed. Also renamed HttpDebug to HTTPDebug in the Options struct. Unfortunately due to the way the statsd and datadog share the same struct for a config this doesn't fix the issue as a whole for them.
na--
reviewed
Oct 24, 2019
There was a problem hiding this comment.
I know it's extra effort, but the mixed capitalization of the envconfig tags is bugging me 😅 Can you make all envconfig tags uppercase? You should be able to do it with a regex: http://bigdatums.net/2017/09/30/how-to-uppercase-lowercase-text-with-sed/
Codecov Report
@@ Coverage Diff @@
## master #1215 +/- ##
==========================================
+ Coverage 73.65% 73.66% +<.01%
==========================================
Files 147 147
Lines 10641 10645 +4
==========================================
+ Hits 7838 7842 +4
Misses 2344 2344
Partials 459 459
Continue to review full report at Codecov.
|
using: ``` rg -g "*.go" 'envconfig:"' --files-with-matches |\ xargs -n 1 sed -r -i -s 's/envconfig:"([^"]*)"/envconfig:"\U\1\E"/g' ```
na--
approved these changes
Oct 25, 2019
cuonglm
approved these changes
Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works on #671 and fixing it in almost all cases.
This was done primarily by running:
And than manually fixing all remaing problems by hand.
In the mean time I found out we weren't properly combing the
configuration for statsd/datadog and fixed.
Also renamed HttpDebug to HTTPDebug in the Options struct.
Unfortunately due to the way the statsd and datadog share the same
struct for a config this doesn't fix the issue as a whole for them.