-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release k6 v0.26.0 #1231
Release k6 v0.26.0 #1231
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1231 +/- ##
==========================================
+ Coverage 75.42% 75.43% +0.01%
==========================================
Files 150 150
Lines 10883 10883
==========================================
+ Hits 8208 8210 +2
+ Misses 2209 2207 -2
Partials 466 466
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My English grammar/spelling is not great, so I just commented on things I found :D
It's probably fine to have some mistakes in the release notes anyway, so it's not a big deal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the inline suggestions and comments, I noticed that we're inconsistently missing dots at the end of sentences in the "Internals" and "Bugs fixed" sections. We had them in previous release notes, because from time to time, you need to fit multiple sentences in one of these list items, for example:
- Metrics: Emit iterations as part of
netext.NetTrail
, instead of as a standalone one. Also cutting down on amount of bytes we sent to the cloud output (Emit iterations metric as part of netext.NetTrail #1203)
it doesn't make sense to have a dot in the first sentence, but no the second
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I pushed a few nitpicks in 97fed04. Feel free to cherry-pick. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the last minor correction, and the PR description, this LGTM now. Feel free to squash everything into a single commit, so we can merge and release 🎉
0cb0377
to
69b1c7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of minor suggestions.
d1d59be
to
af6500d
Compare
No description provided.