add ExportBytes allowing use of Uint8Array for binary requests #1287
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1287 +/- ##
==========================================
- Coverage 75.44% 75.38% -0.06%
==========================================
Files 150 151 +1
Lines 10885 10924 +39
==========================================
+ Hits 8212 8235 +23
- Misses 2207 2216 +9
- Partials 466 473 +7
Continue to review full report at Codecov.
|
Co-Authored-By: na-- <n@andreev.sh>
| "github.com/dop251/goja" | ||
| ) | ||
|
|
||
| func ExportBytes(rt *goja.Runtime, val goja.Value) interface {} { |
There was a problem hiding this comment.
exported function ExportBytes should have comment or be unexported (from golint)
| for _, tt := range nativeTests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| rt := goja.New() | ||
| val := rt.ToValue(tt.arg) |
There was a problem hiding this comment.
Using the variable on range scope tt in function literal (from scopelint)
| t.Run(tt.name, func(t *testing.T) { | ||
| rt := goja.New() | ||
| val := rt.ToValue(tt.arg) | ||
| if got := ExportBytes(rt, val); !reflect.DeepEqual(got, tt.arg) { |
There was a problem hiding this comment.
Using the variable on range scope tt in function literal (from scopelint)
| rt := goja.New() | ||
| val := rt.ToValue(tt.arg) | ||
| if got := ExportBytes(rt, val); !reflect.DeepEqual(got, tt.arg) { | ||
| t.Errorf("ExportBytes() = %v, want %v", got, tt.arg) |
There was a problem hiding this comment.
Using the variable on range scope tt in function literal (from scopelint)
| // need core js for Uint8Array | ||
| _, err := rt.RunProgram(jslib.GetCoreJS()) | ||
| assert.NoError(t, err) | ||
| _, err = rt.RunString(tt.jsCode) |
There was a problem hiding this comment.
Using the variable on range scope tt in function literal (from scopelint)
| assert.NoError(t, err) | ||
| jsVal := rt.Get(tt.jsVarName) | ||
| got := ExportBytes(rt, jsVal) | ||
| if !reflect.DeepEqual(got, tt.want) { |
There was a problem hiding this comment.
Using the variable on range scope tt in function literal (from scopelint)
| jsVal := rt.Get(tt.jsVarName) | ||
| got := ExportBytes(rt, jsVal) | ||
| if !reflect.DeepEqual(got, tt.want) { | ||
| t.Errorf("ExportBytes() = %v, want %v", got, tt.want) |
There was a problem hiding this comment.
Using the variable on range scope tt in function literal (from scopelint)
| // } | ||
| return buf | ||
| } | ||
|
|
There was a problem hiding this comment.
File is not goimports-ed (from goimports)
| } | ||
|
|
||
| jsTests := []struct { | ||
| name string |
There was a problem hiding this comment.
File is not goimports-ed (from goimports)
| t.Errorf("ExportBytes() = %v, want %v", got, tt.want) | ||
| } | ||
| }) | ||
|
|
There was a problem hiding this comment.
unnecessary trailing newline (from whitespace)
|
|
|
Hi @caseylucas , sorry for the extemely wait reply. We were in the middle of reevaluating and #1007 in order to finally be able to get it out and I meant to try this out and figure out if this can be used temporarely ... but never got to it. At this point, goja has ArrayBuffer support and that is definetely way better than what you proposed. Again I still haven't actually gotten to trying it out with the k6 APIs and fixing them accordingly but at least from running some scripts that previously broke it seemed to work way better. Hopefully, in v0.30.0 we will get some time to test this and document how well (or not) it works. Thanks again for this PR - it did lead to me looking into some other stuff at the time, and hopefully helped you and somebody else so it wasn't for nothing :) |
This PR is a starting point for discussion. (See #1020). I implemented support for using core-js
Uint8Arrays as request body so that binary data can be sent in requests. The caveat is that the core-jsUint8Arrayimplementation is slow (compared to golang byte slices). SeeBenchmarkExportByteswhere I benchmarked a few different scenarios. If the JavaScript author just needs an array-like object that can be used for binary data, then I think k6 could proved a JS call to allocate a golang byte slice that is usable in JS (seeexample.ByteSlicefunc.) This is much faster than usingUint8Array. TheExportBytefunction (used byfunc (h *HTTP) Request()) as it stands now supports Uint8Array but also supports []byte as well.