Exclude no work executor #1307
Merged
Exclude no work executor #1307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuonglm
force-pushed
the
fix/issue-1295
branch
from
5638447 to
17c9865
Compare
For executor which has nothing to do in a given segment, we should not include it in the list of executors. To do it, add new method HasWork to ExecutorConfig. By filtering out no work executor when creating new schedulter, we can prevents any un-necessary works and provide better UX. Fixes #1295
cuonglm
force-pushed
the
fix/issue-1295
branch
from
17c9865 to
0fec90c
Compare
Codecov Report
@@ Coverage Diff @@
## new-schedulers #1307 +/- ##
=================================================
+ Coverage 74.92% 75% +0.07%
=================================================
Files 159 159
Lines 12288 12311 +23
=================================================
+ Hits 9207 9234 +27
+ Misses 2590 2587 -3
+ Partials 491 490 -1
Continue to review full report at Codecov.
|
na--
requested changes
Jan 10, 2020
na--
previously approved these changes
Jan 13, 2020
mstoykov
previously approved these changes
Jan 14, 2020
mstoykov
reviewed
Jan 14, 2020
| logger.Warnf( | ||
| "Executor '%s' is disabled for segment %s due to lack of work!", | ||
| sc.GetName(), options.ExecutionSegment, | ||
| ) |
There was a problem hiding this comment.
I am wondering if instead of
WARN[0000] Executor 'shared_iters1' is disabled for segment 1/2:3/4 due to lack of work!
executor: local
output: -
script: 1295.js
execution: (25.00%) 3 executors, 2 max VUs, 10m30s max duration (incl. graceful stop):
* constant_arr_rate: 0.75 iterations/s for 20s (maxVUs: 1, gracefulStop: 30s)
* shared_iters1: 0 iterations shared among 0 VUs (maxDuration: 10m0s, gracefulStop: 30s)
* shared_iters2: 1 iterations shared among 1 VUs (maxDuration: 10m0s, gracefulStop: 30s)
running (00m20.1s), 0/2 VUs, 15 complete and 0 interrupted iterations
constant_arr_rate [======================================] 0.75 iters/s, 1 out of 1 VUs active done!
shared_iters2 [======================================] 1/1 shared iters among 1 VUs done!
data_received........: 0 B 0 B/s
data_sent............: 0 B 0 B/s
iteration_duration...: avg=33.41µs min=4.91µs med=24.81µs max=87.14µs p(90)=74.71µs p(95)=82.18µs
iterations...........: 15 0.745541/s
vus..................: 1 min=1 max=1
it would be better to be just before the progressbars
executor: local
output: -
script: 1295.js
execution: (25.00%) 3 executors, 2 max VUs, 10m30s max duration (incl. graceful stop):
* constant_arr_rate: 0.75 iterations/s for 20s (maxVUs: 1, gracefulStop: 30s)
* shared_iters1: 0 iterations shared among 0 VUs (maxDuration: 10m0s, gracefulStop: 30s)
* shared_iters2: 1 iterations shared among 1 VUs (maxDuration: 10m0s, gracefulStop: 30s)
WARN[0000] Executor 'shared_iters1' is disabled for segment 1/2:3/4 due to lack of work!
running (00m20.1s), 0/2 VUs, 15 complete and 0 interrupted iterations
constant_arr_rate [======================================] 0.75 iters/s, 1 out of 1 VUs active done!
shared_iters2 [======================================] 1/1 shared iters among 1 VUs done!
data_received........: 0 B 0 B/s
data_sent............: 0 B 0 B/s
iteration_duration...: avg=33.41µs min=4.91µs med=24.81µs max=87.14µs p(90)=74.71µs p(95)=82.18µs
iterations...........: 15 0.745541/s
vus..................: 1 min=1 max=1
There was a problem hiding this comment.
it will be a bit better, yeah.... though that would require some very refactoring that I'm not sure I want to do right now... basically, we'd have to reorder a lot of cmd/run.go to achieve this 😞
There was a problem hiding this comment.
okay let's leave it for a future PR
imiric
approved these changes
Jan 14, 2020
mstoykov
approved these changes
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For executor which has nothing to do in a given segment, we should not
include it in the list of executors.
To do it, add new method HasWork to ExecutorConfig. By filtering out no
work executor when creating new schedulter, we can prevents any un-necessary
works and provide better UX.
Fixes #1295