Add test for ExecutionSegment.Scale consistency #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imiric
commented
Mar 26, 2020
na--
reviewed
Mar 26, 2020
Codecov Report
@@ Coverage Diff @@
## new-schedulers #1374 +/- ##
==================================================
- Coverage 76.32% 76.30% -0.02%
==================================================
Files 161 161
Lines 12625 12625
==================================================
- Hits 9636 9634 -2
- Misses 2479 2481 +2
Partials 510 510
Continue to review full report at Codecov.
|
na--
approved these changes
Mar 26, 2020
mstoykov
approved these changes
Mar 30, 2020
|
|
||
| const numTests = 10 | ||
| for i := 0; i < numTests; i++ { | ||
| scale := rand.Int31n(99) + 2 |
There was a problem hiding this comment.
As I previously rebased these particular tests and used for testing the striping PR I can tell you that having values that are both smaller then the count of the segments and bigger is ... a good idea :D
I think that we can do something like:
- get the number of segments(this is the first argument to
generateRandomSequence - generate random numbers and run test for scale being smaller, equal and bigger to the count of segments.
There was a problem hiding this comment.
Hhmm not sure what that would look like, but I'll think about it next time I touch these tests, thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a test from #1339, which did a bunch of things that are not needed anymore, so this is a cut-down version of that.
See #1296