Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split StatsD and Datadog config #1655

Merged
merged 1 commit into from
Oct 13, 2020
Merged

Conversation

imiric
Copy link
Contributor

@imiric imiric commented Oct 6, 2020

This addresses the suggestion in this comment in order to close #671.

I tested the integration with a local StatsD instance and with Datadog and it works OK.

@imiric imiric requested review from mstoykov and na-- October 6, 2020 14:18
@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2020

Codecov Report

Merging #1655 into master will decrease coverage by 0.06%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1655      +/-   ##
==========================================
- Coverage   72.16%   72.09%   -0.07%     
==========================================
  Files         166      165       -1     
  Lines       12787    12806      +19     
==========================================
+ Hits         9228     9233       +5     
- Misses       3009     3015       +6     
- Partials      550      558       +8     
Impacted Files Coverage Δ
cmd/collectors.go 0.00% <0.00%> (ø)
stats/datadog/collector.go 74.19% <52.94%> (-25.81%) ⬇️
stats/statsd/collector.go 65.21% <55.55%> (-34.79%) ⬇️
cmd/config.go 82.35% <100.00%> (ø)
stats/statsd/common/collector.go 81.92% <100.00%> (ø)
stats/statsd/common/testutil/test_helper.go 97.75% <100.00%> (+0.02%) ⬆️
lib/executor/vu_handle.go 95.23% <0.00%> (+1.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b75efd...37fabef. Read the comment docs.

Copy link
Contributor

@mstoykov mstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I was thinking of just having the parsing of the config to be in the corresponding package and that to be then transcoded to the common.Config and mostly no other changes. But I think I figured out there is a problem with that approach back when I left this unfinished and a little more code is not a problem :)

@na-- na-- added this to the v0.29.0 milestone Oct 13, 2020
@imiric imiric merged commit 62b564f into master Oct 13, 2020
@imiric imiric deleted the fix/671-split-statsd-datadog-config branch October 13, 2020 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Env variable DURATION is being used implicitly
4 participants