Update goja to latest master #2170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstoykov
requested review from
inancgumus,
imiric,
codebien,
yorugac and
na--
na--
reviewed
Oct 11, 2021
|
I have opened an issue for the failing tests after the disabling. Given the failures I don't think there are many if any users of k6 that will hit this, but still merging this close to 0.35.0 release date might not be advisable ;) |
codebien
previously approved these changes
Oct 12, 2021
imiric
previously approved these changes
Oct 12, 2021
codebien
approved these changes
Oct 12, 2021
na--
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds template literal support