Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Grammatical correction in readme file #2181

Merged
merged 3 commits into from
Oct 13, 2021
Merged

fix: Grammatical correction in readme file #2181

merged 3 commits into from
Oct 13, 2021

Conversation

idivyanshbansal
Copy link
Contributor

@idivyanshbansal idivyanshbansal commented Oct 12, 2021

Done grammatical correction in readme file

@CLAassistant
Copy link

CLAassistant commented Oct 12, 2021

CLA assistant check
All committers have signed the CLA.

README.md Outdated

- Run `go get go.k6.io/k6` which will:
- git clone the repo and put the source in `$GOPATH/src/go.k6.io/k6`
- build a `k6` binary and put it in `$GOPATH/bin`
- Make sure you have `$GOPATH/bin` in your `PATH` (or copy the `k6` binary somewhere in your `PATH`), so you are able to run k6 from any location.
- Tada, you can now run k6 using `k6 run script.js`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is still "k6" with a lower case k. Every page on the k6 website has "k6" and nowhere it's "K6" (not even in the logo)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@efdknittlfrank but being Capital for K is more professional.

Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k6 should be lowercase

@idivyanshbansal
Copy link
Contributor Author

k6 should be lowercase

Okay, @na--

Just a minute

@idivyanshbansal
Copy link
Contributor Author

@na--, I have updated it.

README.md Outdated Show resolved Hide resolved
@idivyanshbansal
Copy link
Contributor Author

Thank you @na-- for approving. 🤩

@na-- na-- merged commit 854f83e into grafana:master Oct 13, 2021
@idivyanshbansal
Copy link
Contributor Author

Thankyou to all of you guys. You are awesome 🤩🤩🤩🙌🙌🙌
Is this PR can claim your cool swags

@idivyanshbansal
Copy link
Contributor Author

@na-- sir Please add the hacktoberfest label to it
They are not considering it 😥
Screenshot 2021-10-13 174532

@na--
Copy link
Member

na-- commented Oct 14, 2021

From what I understand, you shouldn't need this, since the repo is already tagged and we've merged the PR, but I've added it... 🤷‍♂️

@idivyanshbansal
Copy link
Contributor Author

@na-- Thank you, Sir.Sorry for incovinece

@mstoykov mstoykov added this to the v0.35.0 milestone Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants