Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release k6 v0.35.0 #2227

Merged
merged 2 commits into from
Nov 17, 2021
Merged

Release k6 v0.35.0 #2227

merged 2 commits into from
Nov 17, 2021

Conversation

yorugac
Copy link
Contributor

@yorugac yorugac commented Nov 8, 2021

No description provided.

@github-actions github-actions bot requested review from codebien and mstoykov November 8, 2021 14:45
Copy link
Contributor

@codebien codebien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, thanks 👏 Few minor things.

release notes/v0.35.0.md Outdated Show resolved Hide resolved
release notes/v0.35.0.md Outdated Show resolved Hide resolved
release notes/v0.35.0.md Outdated Show resolved Hide resolved

## Maintenance

- Update a whole bunch of dependencies ([#2159](https://github.com/grafana/k6/pull/2159), [#2170](https://github.com/grafana/k6/pull/2170), [#2165](https://github.com/grafana/k6/pull/2165)).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any of them includes some relevant/impacting changes that have to be communicated to users?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are golang lib updates and alpine image update: they're useful but it seems to me they shouldn't impact average user much. The 3rd issue here is another goja update -> template literals. I didn't re-check by hand but it was mentioned somewhere in chats that feature was supported even before, just with Babel, so it means it's no major change from user's perspective.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that feature was supported even before

probably is bit better supported as usual as Babel has it's limits and is a bit old now. I don't think we should mention it for that, but mostly as this means that babel will now transpile even less stuff which means that it's a bit faster. For the octal/binary literals that meant for a specific script that was taking over 3 minutes to transpile that it went down to just under 1minute, which is quite considerable change for the people who have big scripts with specific features, in this case I think a big POST body with binary/octal literals.

The rest of the changes are probably mostly fixes for http2 which got a ton of fixes in this release

release notes/v0.35.0.md Outdated Show resolved Hide resolved
release notes/v0.35.0.md Outdated Show resolved Hide resolved
@codebien
Copy link
Contributor

codebien commented Nov 8, 2021

@Olha test-tip is failing

@yorugac
Copy link
Contributor Author

yorugac commented Nov 8, 2021

Yes, it's not a flaky one but caused by a new version of go-tip 😂 Apparently, it went from go1.18-2622235 (last week) to go1.18-ab31dbc (~today) and broke something in our tests.
This PR doesn't have any code, and this failure will likely repeat on any new PR.

@yorugac
Copy link
Contributor Author

yorugac commented Nov 8, 2021

Source of the problem: golang/go@035963c

Copy link
Contributor

@codebien codebien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one minor thing, the rest LGTM

release notes/v0.35.0.md Outdated Show resolved Hide resolved
codebien
codebien previously approved these changes Nov 10, 2021
Copy link
Contributor

@codebien codebien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@na-- na-- added this to the v0.35.0 milestone Nov 11, 2021
@@ -0,0 +1,94 @@
k6 v0.35.0 is here! :tada: It introduces several new features that nicely enhance usage of k6 as well as contains a whole number of fixes and ongoing efforts with refactoring.

In total, we have closed 14 issues and merged 43 PRs. We have also branched out three new xk6 extensions during this release :star:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we doing these statistics now? I am not really for or against, just asking as we might want to double-check that then as I definitely didn't move every PR to v0.35.0 as some of them were README changes and I didn't find that useful, but the number is probably bigger if you just looked at what is in the milestone.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, those numbers are the ones labeled with the milestone.
If it's the norm not to label PRs with milestone based on their usefulness (is it?) then yes, not sure if stats would makes sense at all 😕 They definitely won't be sustainable then. I can remove it now, but it's something to think about in the future probably.

release notes/v0.35.0.md Outdated Show resolved Hide resolved
release notes/v0.35.0.md Outdated Show resolved Hide resolved
release notes/v0.35.0.md Outdated Show resolved Hide resolved
release notes/v0.35.0.md Outdated Show resolved Hide resolved
release notes/v0.35.0.md Outdated Show resolved Hide resolved
release notes/v0.35.0.md Outdated Show resolved Hide resolved
release notes/v0.35.0.md Outdated Show resolved Hide resolved

## Maintenance

- Update a whole bunch of dependencies ([#2159](https://github.com/grafana/k6/pull/2159), [#2170](https://github.com/grafana/k6/pull/2170), [#2165](https://github.com/grafana/k6/pull/2165)).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that feature was supported even before

probably is bit better supported as usual as Babel has it's limits and is a bit old now. I don't think we should mention it for that, but mostly as this means that babel will now transpile even less stuff which means that it's a bit faster. For the octal/binary literals that meant for a specific script that was taking over 3 minutes to transpile that it went down to just under 1minute, which is quite considerable change for the people who have big scripts with specific features, in this case I think a big POST body with binary/octal literals.

The rest of the changes are probably mostly fixes for http2 which got a ton of fixes in this release

release notes/v0.35.0.md Outdated Show resolved Hide resolved
release notes/v0.35.0.md Outdated Show resolved Hide resolved
release notes/v0.35.0.md Show resolved Hide resolved
release notes/v0.35.0.md Show resolved Hide resolved
release notes/v0.35.0.md Outdated Show resolved Hide resolved
release notes/v0.35.0.md Outdated Show resolved Hide resolved
release notes/v0.35.0.md Outdated Show resolved Hide resolved

- k6's GRPC was extended with a support for server reflection which allows one to use GRPC even without `proto` file at hand. You can read more about the protocol [here](https://github.com/grpc/grpc/blob/master/doc/server-reflection.md) ([#2160](https://github.com/grafana/k6/pull/2160)).
- Support for cookies in `k6/ws` ([#2193](https://github.com/grafana/k6/pull/2193)).
- Forbid `metric.Add` to let `NaN` values through ([#1876](https://github.com/grafana/k6/pull/1876)); instead, print out nice warnings or throw an exception if `--throw` is enabled. These warnings will not become too large ([#2219](https://github.com/grafana/k6/pull/2219)).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we can skip These warnings will not become too large, we can just add the second PR in the brackets, like this:

Suggested change
- Forbid `metric.Add` to let `NaN` values through ([#1876](https://github.com/grafana/k6/pull/1876)); instead, print out nice warnings or throw an exception if `--throw` is enabled. These warnings will not become too large ([#2219](https://github.com/grafana/k6/pull/2219)).
- Forbid `metric.Add` to let `NaN` values for custom metrics through. Instead, k6 will log nice warnings or throw an exception if `--throw` is enabled ([#1876](https://github.com/grafana/k6/pull/1876), [#2219](https://github.com/grafana/k6/pull/2219)).

release notes/v0.35.0.md Outdated Show resolved Hide resolved
release notes/v0.35.0.md Outdated Show resolved Hide resolved
release notes/v0.35.0.md Outdated Show resolved Hide resolved
@CLAassistant
Copy link

CLAassistant commented Nov 16, 2021

CLA assistant check
All committers have signed the CLA.

mstoykov
mstoykov previously approved these changes Nov 16, 2021
@@ -0,0 +1,134 @@
k6 v0.35.0 is here! :tada: It introduces several new features that nicely enhance its usability and also contains a whole lot of fixes and ongoing efforts with refactoring.

In total, we have closed 14 issues. We have also branched out three new xk6 extensions during this release :star:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In total, we have closed 14 issues. We have also branched out three new xk6 extensions during this release :star:
In total, we have closed 14 issues. We have also branched out three new [xk6 extensions](https://k6.io/docs/misc/k6-extensions/) during this release :star:

Doesn't hurt to always link to the docs, some users might have never heard about xk6 🤷‍♂️

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense but now that I've added it, this actually looks strange to me as I'd think the link leads to those three extensions 😅

release notes/v0.35.0.md Outdated Show resolved Hide resolved
release notes/v0.35.0.md Outdated Show resolved Hide resolved
release notes/v0.35.0.md Outdated Show resolved Hide resolved
release notes/v0.35.0.md Outdated Show resolved Hide resolved
release notes/v0.35.0.md Outdated Show resolved Hide resolved
Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides the minor nitpics I noted inline

@na-- na-- self-requested a review November 16, 2021 14:58
@yorugac yorugac force-pushed the release-notes/35 branch 2 times, most recently from 3780a37 to 7287c06 Compare November 16, 2021 16:44
@yorugac yorugac requested review from mstoykov and codebien November 16, 2021 16:46
release notes/v0.35.0.md Outdated Show resolved Hide resolved
@yorugac yorugac requested a review from na-- November 17, 2021 08:19
mstoykov
mstoykov previously approved these changes Nov 17, 2021
@yorugac yorugac changed the title Release notes for v0.35.0 Release k6 v0.35.0 Nov 17, 2021
@yorugac yorugac requested a review from mstoykov November 17, 2021 08:48
Copy link
Contributor

@codebien codebien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yorugac 👏

@yorugac yorugac merged commit 1c44b2d into master Nov 17, 2021
@yorugac yorugac deleted the release-notes/35 branch November 17, 2021 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants