-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release k6 v0.35.0 #2227
Release k6 v0.35.0 #2227
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super, thanks 👏 Few minor things.
|
||
## Maintenance | ||
|
||
- Update a whole bunch of dependencies ([#2159](https://github.com/grafana/k6/pull/2159), [#2170](https://github.com/grafana/k6/pull/2170), [#2165](https://github.com/grafana/k6/pull/2165)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any of them includes some relevant/impacting changes that have to be communicated to users?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are golang lib updates and alpine image update: they're useful but it seems to me they shouldn't impact average user much. The 3rd issue here is another goja update -> template literals. I didn't re-check by hand but it was mentioned somewhere in chats that feature was supported even before, just with Babel, so it means it's no major change from user's perspective.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that feature was supported even before
probably is bit better supported as usual as Babel has it's limits and is a bit old now. I don't think we should mention it for that, but mostly as this means that babel will now transpile even less stuff which means that it's a bit faster. For the octal/binary literals that meant for a specific script that was taking over 3 minutes to transpile that it went down to just under 1minute, which is quite considerable change for the people who have big scripts with specific features, in this case I think a big POST body with binary/octal literals.
The rest of the changes are probably mostly fixes for http2 which got a ton of fixes in this release
@Olha |
Yes, it's not a flaky one but caused by a new version of go-tip 😂 Apparently, it went from |
Source of the problem: golang/go@035963c |
3eb6ece
to
6a5b408
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one minor thing, the rest LGTM
6a5b408
to
8bd5490
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
release notes/v0.35.0.md
Outdated
@@ -0,0 +1,94 @@ | |||
k6 v0.35.0 is here! :tada: It introduces several new features that nicely enhance usage of k6 as well as contains a whole number of fixes and ongoing efforts with refactoring. | |||
|
|||
In total, we have closed 14 issues and merged 43 PRs. We have also branched out three new xk6 extensions during this release :star: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we doing these statistics now? I am not really for or against, just asking as we might want to double-check that then as I definitely didn't move every PR to v0.35.0 as some of them were README changes and I didn't find that useful, but the number is probably bigger if you just looked at what is in the milestone.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, those numbers are the ones labeled with the milestone.
If it's the norm not to label PRs with milestone based on their usefulness (is it?) then yes, not sure if stats would makes sense at all 😕 They definitely won't be sustainable then. I can remove it now, but it's something to think about in the future probably.
|
||
## Maintenance | ||
|
||
- Update a whole bunch of dependencies ([#2159](https://github.com/grafana/k6/pull/2159), [#2170](https://github.com/grafana/k6/pull/2170), [#2165](https://github.com/grafana/k6/pull/2165)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that feature was supported even before
probably is bit better supported as usual as Babel has it's limits and is a bit old now. I don't think we should mention it for that, but mostly as this means that babel will now transpile even less stuff which means that it's a bit faster. For the octal/binary literals that meant for a specific script that was taking over 3 minutes to transpile that it went down to just under 1minute, which is quite considerable change for the people who have big scripts with specific features, in this case I think a big POST body with binary/octal literals.
The rest of the changes are probably mostly fixes for http2 which got a ton of fixes in this release
8bd5490
to
9d156b4
Compare
release notes/v0.35.0.md
Outdated
|
||
- k6's GRPC was extended with a support for server reflection which allows one to use GRPC even without `proto` file at hand. You can read more about the protocol [here](https://github.com/grpc/grpc/blob/master/doc/server-reflection.md) ([#2160](https://github.com/grafana/k6/pull/2160)). | ||
- Support for cookies in `k6/ws` ([#2193](https://github.com/grafana/k6/pull/2193)). | ||
- Forbid `metric.Add` to let `NaN` values through ([#1876](https://github.com/grafana/k6/pull/1876)); instead, print out nice warnings or throw an exception if `--throw` is enabled. These warnings will not become too large ([#2219](https://github.com/grafana/k6/pull/2219)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we can skip These warnings will not become too large
, we can just add the second PR in the brackets, like this:
- Forbid `metric.Add` to let `NaN` values through ([#1876](https://github.com/grafana/k6/pull/1876)); instead, print out nice warnings or throw an exception if `--throw` is enabled. These warnings will not become too large ([#2219](https://github.com/grafana/k6/pull/2219)). | |
- Forbid `metric.Add` to let `NaN` values for custom metrics through. Instead, k6 will log nice warnings or throw an exception if `--throw` is enabled ([#1876](https://github.com/grafana/k6/pull/1876), [#2219](https://github.com/grafana/k6/pull/2219)). |
9d156b4
to
ed5b2fb
Compare
ed5b2fb
to
5937c62
Compare
5937c62
to
cc897ae
Compare
release notes/v0.35.0.md
Outdated
@@ -0,0 +1,134 @@ | |||
k6 v0.35.0 is here! :tada: It introduces several new features that nicely enhance its usability and also contains a whole lot of fixes and ongoing efforts with refactoring. | |||
|
|||
In total, we have closed 14 issues. We have also branched out three new xk6 extensions during this release :star: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In total, we have closed 14 issues. We have also branched out three new xk6 extensions during this release :star: | |
In total, we have closed 14 issues. We have also branched out three new [xk6 extensions](https://k6.io/docs/misc/k6-extensions/) during this release :star: |
Doesn't hurt to always link to the docs, some users might have never heard about xk6 🤷♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes sense but now that I've added it, this actually looks strange to me as I'd think the link leads to those three extensions 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM besides the minor nitpics I noted inline
3780a37
to
7287c06
Compare
7287c06
to
e5b5e04
Compare
e5b5e04
to
37072b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yorugac 👏
No description provided.