Simplify requirements calculation in k6 inspect
#2444
Conversation
| // | ||
| // TODO: completely remove this? | ||
| func (r *Runner) IsExecutable(name string) bool { | ||
| _, exists := r.Bundle.exports[name] | ||
| return exists | ||
| return r.Bundle.IsExecutable(name) | ||
| } |
There was a problem hiding this comment.
This is used so unless we change the Runner interfaces it's needed to stay. Arguably the Runner interface is quite big and IMO has parts that have just been piled one over the years. A full redesign though is probably better left for later.
I just did look into it and I think IsExecutualbe as well as Setup/Teardown around stuff should probably be moved to not the Runner and consolidated a bunch. Unfortunately that looks like it will need a lot of changes across k6 and some unknown unknowns that I don't think we should try to figure out now.
But tl;dr: you can't remove this, easily
There was a problem hiding this comment.
Yeah, I already addressed it in #2409 (comment), but I remove this TODO in a future PR, for now I'd prefer to merge it just so I don't have to rebase everything again.
But yeah, mid to long term, now that we have a (hopefully) viable solution for refactoring the mess of the Engine away, we really need to start looking at refactoring the Runner mess 😞 See also this comment from one of the other PRs #2412 (comment)
We didn't end up merging more PRs in the
nextbranch, so this is exactly the same as #2409, only a PR tomasterthis time