Update xk6-output-prometheus-remote
to its latest main
commit
#3210
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This allows us to make all
metrics.TrendSink
properties private and finish that refactoring effort. It is built on top of grafana/xk6-output-prometheus-remote#133, and both are the continuation of themetrics.TrendSink
refactoring that started in #3191.All of this rigmarole and complexity with multiple PRs was needed simply because of how experimenal modules from external repositories work 😞
Why?
All of these PRs are needed if we want to have HDR histograms or to support metrics in distributed k6 execution. Being able to access the internal
struct
properties directly anywhere in k6 (or outside of it, as was the case here!) prevented us from refactoring these "internals".Checklist
make ci-like-lint
) and all checks pass.make tests
) and all tests pass.Related PR(s)/Issue(s)