Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xk6-output-prometheus-remote to its latest main commit #3210

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

na--
Copy link
Member

@na-- na-- commented Jul 19, 2023

What?

This allows us to make all metrics.TrendSink properties private and finish that refactoring effort. It is built on top of grafana/xk6-output-prometheus-remote#133, and both are the continuation of the metrics.TrendSink refactoring that started in #3191.

All of this rigmarole and complexity with multiple PRs was needed simply because of how experimenal modules from external repositories work 😞

Why?

All of these PRs are needed if we want to have HDR histograms or to support metrics in distributed k6 execution. Being able to access the internal struct properties directly anywhere in k6 (or outside of it, as was the case here!) prevented us from refactoring these "internals".

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make ci-like-lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@na-- na-- requested review from oleiade and olegbespalov July 19, 2023 11:00
This allows us to make all TrendSink properties private and finish that refactoring effort.
@na-- na-- force-pushed the update-promrw-output branch from d930752 to 11349b3 Compare July 19, 2023 11:13
@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2023

Codecov Report

Merging #3210 (e7e2141) into master (1278f6e) will increase coverage by 0.17%.
The diff coverage is 89.84%.

❗ Current head e7e2141 differs from pull request most recent head 11349b3. Consider uploading reports for the commit 11349b3 to get more accurate results

@@            Coverage Diff             @@
##           master    #3210      +/-   ##
==========================================
+ Coverage   72.69%   72.87%   +0.17%     
==========================================
  Files         254      259       +5     
  Lines       19802    19810       +8     
==========================================
+ Hits        14396    14437      +41     
+ Misses       4497     4473      -24     
+ Partials      909      900       -9     
Flag Coverage Δ
ubuntu 72.81% <89.84%> (?)
windows 72.71% <89.84%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
metrics/engine/ingester.go 91.48% <ø> (ø)
output/cloud/expv2/collect.go 92.59% <ø> (+0.51%) ⬆️
output/cloud/expv2/flush.go 91.04% <ø> (-0.85%) ⬇️
output/cloud/expv2/output.go 65.55% <14.28%> (-0.20%) ⬇️
cmd/run.go 74.27% <86.66%> (+0.11%) ⬆️
output/cloud/insights/collect.go 91.48% <91.48%> (ø)
metrics/sink.go 97.40% <96.42%> (+1.51%) ⬆️
cloudapi/config.go 90.90% <100.00%> (ø)
execution/scheduler.go 93.09% <100.00%> (+0.36%) ⬆️
metrics/engine/engine.go 90.26% <100.00%> (+1.28%) ⬆️
... and 4 more

... and 12 files with indirect coverage changes

Copy link
Contributor

@olegbespalov olegbespalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@olegbespalov olegbespalov added this to the v0.46.0 milestone Jul 19, 2023
@na-- na-- merged commit dccdf16 into master Jul 19, 2023
@na-- na-- deleted the update-promrw-output branch July 19, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants