Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update xk6-websockets to fix readyState bug #3972

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Update xk6-websockets to fix readyState bug #3972

merged 1 commit into from
Sep 30, 2024

Conversation

mstoykov
Copy link
Contributor

What?

Update xk6-websockets

Why?

Fix readyState in k6/experimental/websockets to actually be a number.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@mstoykov mstoykov added this to the v0.54.0 milestone Sep 30, 2024
@mstoykov mstoykov requested a review from a team as a code owner September 30, 2024 07:05
@mstoykov mstoykov requested review from olegbespalov and joanlopez and removed request for a team September 30, 2024 07:05
@olegbespalov olegbespalov added the dependencies Pull requests that update a dependency file label Sep 30, 2024
@mstoykov mstoykov merged commit 7e82c3d into master Sep 30, 2024
22 checks passed
@mstoykov mstoykov deleted the updateXk6Websockets branch September 30, 2024 07:52
@BrewTestBot BrewTestBot mentioned this pull request Sep 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olegbespalov olegbespalov olegbespalov approved these changes

@joanlopez joanlopez joanlopez approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
v0.54.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mstoykov @olegbespalov @joanlopez