Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(673) - summary output in execution order #674

Merged
merged 1 commit into from
Jun 18, 2018

Conversation

openmohan
Copy link
Contributor

Fixes - In Summary the checkNames and groupNames are being sorted, so cli-summary is not same as the execution order

Closes - 673

@codecov-io
Copy link

Codecov Report

Merging #674 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #674      +/-   ##
==========================================
+ Coverage   64.62%   64.64%   +0.01%     
==========================================
  Files         101      101              
  Lines        8162     8160       -2     
==========================================
  Hits         5275     5275              
+ Misses       2546     2544       -2     
  Partials      341      341
Impacted Files Coverage Δ
ui/summary.go 17.89% <ø> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3ae301...b323cf4. Read the comment docs.

Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing this, I agree that it makes more sense to have the groups and checks in the original execution order.

@na-- na-- requested a review from luizbafilho June 14, 2018 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants