-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Builds deb, rpm, msi and chocolatey packages #675
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a question around the use of the docker compose file.
docker-compose.yml
Outdated
@@ -25,3 +25,21 @@ services: | |||
environment: | |||
- K6_OUT=influxdb=http://influxdb:8086/k6 | |||
command: 'version' | |||
|
|||
deb: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, maybe we should have these in a separate docker compose file? Otherwise they'll be run every time someone uses docker-compose.yml
to run InfluxDB+Grafana, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True. Missed that.
Codecov Report
@@ Coverage Diff @@
## master #675 +/- ##
=======================================
Coverage 64.62% 64.62%
=======================================
Files 101 101
Lines 8162 8162
=======================================
Hits 5275 5275
Misses 2546 2546
Partials 341 341 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
packaging/deb.json
Outdated
"name": "k6", | ||
"maintainer": "Load Impact AB", | ||
"description": "Load testing for the 21st century", | ||
"changelog-cmd": "cat './release notes/v0.21.0.md'", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this? We'd have to change it for every release and I'm not sure how pretty the markdown file intended for github would be when you use it as a deb changelog. Also, if I remember correctly, debian changelogs included the full history of the package, not just the changes in the latest release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just saw the command in the rpm.json
spec, that one looks much more maintainable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missed the version
variable, I'll added it
I intend to create automatic package available on the chocolatey gallery. It will contain exe (embedded package) as it is more reliable. This will follow releases on Github daily. |
This PR builds the deb, rpm, MSI and chocolatey packages and publishes them to Bintray
closes #15