Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builds deb, rpm, msi and chocolatey packages #675

Merged
merged 8 commits into from
Jun 21, 2018
Merged

Conversation

luizbafilho
Copy link
Contributor

@luizbafilho luizbafilho commented Jun 16, 2018

This PR builds the deb, rpm, MSI and chocolatey packages and publishes them to Bintray

closes #15

Copy link
Member

@robingustafsson robingustafsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a question around the use of the docker compose file.

@@ -25,3 +25,21 @@ services:
environment:
- K6_OUT=influxdb=http://influxdb:8086/k6
command: 'version'

deb:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, maybe we should have these in a separate docker compose file? Otherwise they'll be run every time someone uses docker-compose.yml to run InfluxDB+Grafana, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. Missed that.

@codecov-io
Copy link

codecov-io commented Jun 18, 2018

Codecov Report

Merging #675 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #675   +/-   ##
=======================================
  Coverage   64.62%   64.62%           
=======================================
  Files         101      101           
  Lines        8162     8162           
=======================================
  Hits         5275     5275           
  Misses       2546     2546           
  Partials      341      341

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3ae301...625c138. Read the comment docs.

Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

"name": "k6",
"maintainer": "Load Impact AB",
"description": "Load testing for the 21st century",
"changelog-cmd": "cat './release notes/v0.21.0.md'",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this? We'd have to change it for every release and I'm not sure how pretty the markdown file intended for github would be when you use it as a deb changelog. Also, if I remember correctly, debian changelogs included the full history of the package, not just the changes in the latest release.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just saw the command in the rpm.json spec, that one looks much more maintainable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed the version variable, I'll added it

@luizbafilho luizbafilho merged commit f85389f into master Jun 21, 2018
@na-- na-- deleted the feature/packaging branch June 25, 2018 07:03
@majkinetor
Copy link

majkinetor commented May 17, 2019

I intend to create automatic package available on the chocolatey gallery. It will contain exe (embedded package) as it is more reliable. This will follow releases on Github daily.

majkinetor/au-packages#109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installers / packaging
5 participants