Add HAR converter options #694
Conversation
na--
changed the title
| // GetPrettyJSON is a massive hack that works around the fact that some | ||
| // of the null-able types used in Options are marshalled to `null` when | ||
| // their `valid` flag is false. | ||
| // TODO: figure out something better or at least use reflect to do it, that |
There was a problem hiding this comment.
In the future we could perhaps compare the keys from the user supplied JSON file + any options from the converter itself (like maxRedirects) with the keys in the options struct and only marshal the ones that have been specified (via some sort of intermediary data struct/container, like you use below for removing the null values). Maybe that's what you mean by "use reflect to do it".
There was a problem hiding this comment.
Not exactly, we can just enumerate struct fields with reflect (in order, compared to the unordered map traversal in Go) and check each one for a nil or a false value of its Valid flag. That way we'll also be able to output invalid JSON, but valid JS object syntax like this (notice the lack of quotes around the key name):
{
maxRedirects: 0
};
There was a problem hiding this comment.
I didn't do it now because reflect is quite finicky and I couldn't be sure that I'd get all of the edge cases correctly..
release notes/upcoming.md
Outdated
| @@ -12,6 +12,7 @@ console.log(rnd) | |||
| ``` | |||
|
|
|||
| * A new option `--no-vu-connection-reuse` lets users close HTTP `keep-alive` connections between iterations of a VU. (#676) | |||
| * New options were added to the HAR converter. You can set the minimum and maximum sleep time at the end of an iteration with the new `--min-sleep` and `--max-sleep` CLI flags of `k6 convert`. You can also specify a JSON file with [script options](https://docs.k6.io/docs/options) that would be added to the options of the generated scripts with the new `--options` flag. (#694) | |||
There was a problem hiding this comment.
I'd separate the --min-sleep/--max-sleep and --options into two separate items.
This adds a new
--optionsflag for injecting options in the HAR converter output script (and closes #690). It also adds new--min-sleepand--max-sleepflags that determine the minimum and maximum sleep times at the end of the iteration in the output script.