Adding no cookies reset option

[luizbafilho]

closes #622

[codecov-io]

Codecov Report

Merging #729 into master will decrease coverage by 0.01%.
The diff coverage is 75%.

@@            Coverage Diff             @@
##           master     #729      +/-   ##
==========================================
- Coverage   64.38%   64.36%   -0.02%     
==========================================
  Files         101      101              
  Lines        8333     8341       +8     
==========================================
+ Hits         5365     5369       +4     
- Misses       2618     2620       +2     
- Partials      350      352       +2

Impacted Files	Coverage Δ
cmd/options.go	61.53% <ø> (ø)	⬆️
lib/options.go	78.7% <100%> (+0.27%)	⬆️
js/runner.go	79.06% <66.66%> (-0.36%)	⬇️
core/engine.go	91.94% <0%> (-0.95%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ffa907...36a4bfc. Read the comment docs.

[na--]

Besides the CLI flag, LGTM

[na--]

Looking at this again, I'm not sure this functionality deserves its own CLI flag. Maybe leave it just as JS/evn. var option for now? We can always add the CLI flag later if users request it.

[luizbafilho]

Good point, I guess we should discuss someday what worth or not a CLI flag. I'll wipe this out for now.

[mercs600]

Hi guys, I have question @luizbafilho. Am I able to run k6 with this new option --no-cookies-reset now ? I'm trying build k6 from sources. But I got ERRO[0000] unknown flag: --no-cookies-reset.
I need this option to share cookies between tests.

[na--]

Hey @mercs600, we didn't add a command-line option for the new setting because we didn't want to overcrowd the CLI interface with an option that probably won't be used very often. If there's enough user demand we can always enable it later, but for now you can still enable the "no cookies reset" functionality it by setting the environment variable K6_NO_COOKIES_RESET to true like this:

export K6_NO_COOKIES_RESET=true 
k6 run myscript.js

or by using the in-script option noCookiesReset like this:

export let options = {
    noCookiesReset: true
};

Sorry for the confusion, I've expanded the upcoming release notes to mention this and later I'll also update the readme.io docs with information about it.

[mercs600]

@na-- thank you. Could you tell me something more ? I'm trying setup cookies in setup() lifecycle. For example I make login action in setup() and there after submitForm with login credentials server returns cookies. I would like to use this cookies in default cycle when tests are executing. Is it possible ? Because right now when I setup it manually by export options I can't do this.

[na--]

Hmm not sure if I correctly understand what you're trying to do, but keep in mind that setup() runs in its own separate JS runtime, and each VU does as well. So you should be able to make a login/signup/etc. http request in setup(), get the cookies from its response and return them from setup so that each VU could access them. Then each VU can just set them in the cookie jar at the beginning of each iteration, you wouldn't even need the noCookiesReset option that way.

In any case, these types of questions and discussions are more suited to the #support channel in the slack chat or for stackoverflow, not closed github issues 😄

[mercs600]

I resolved my issue by getting cookie from previous response in setup() cycle.
Thank you for your help and sorry for reopen ;-)